From owner-freebsd-ports-bugs@freebsd.org  Tue Dec 15 02:21:26 2015
Return-Path: <owner-freebsd-ports-bugs@freebsd.org>
Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0E264A4799F
 for <freebsd-ports-bugs@mailman.ysv.freebsd.org>;
 Tue, 15 Dec 2015 02:21:26 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id F30CC18E1
 for <freebsd-ports-bugs@FreeBSD.org>; Tue, 15 Dec 2015 02:21:25 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id tBF2LPJA096387
 for <freebsd-ports-bugs@FreeBSD.org>; Tue, 15 Dec 2015 02:21:25 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 205328] devel/oniguruma5: Use GITHUB for DISTFILES
Date: Tue, 15 Dec 2015 02:21:26 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: easy, needs-qa, patch
X-Bugzilla-Severity: Affects Many People
X-Bugzilla-Who: koobs@FreeBSD.org
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: short_desc cc keywords
Message-ID: <bug-205328-13-7STNpIEqDQ@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-205328-13@https.bugs.freebsd.org/bugzilla/>
References: <bug-205328-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Dec 2015 02:21:26 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205328

Kubilay Kocak <koobs@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|UPDATE: devel/oniguruma5 to |devel/oniguruma5: Use
                   |use github                  |GITHUB for DISTFILES
                 CC|                            |koobs@FreeBSD.org
           Keywords|                            |easy, needs-qa, patch

--- Comment #1 from Kubilay Kocak <koobs@FreeBSD.org> ---
Thanks for your submission Robert. At least few further tweaks are needed:

* GH_PROJECT is PORTNAME by default, you can remove this
* For GH_TAGNAME, if the repository has git tags, please use them instead of
commit hashes. Note: GH_TAGNAME defaults to PORTVERSION already
* INSTALL_TARGET=install-strip shouldn't be removed without good reason.
* You should be able to use USES=pathfix instead of:

@${REINPLACE_CMD} -e 's|\$$(libdir)/pkgconfig| for CMakeLists.txt and
Makefile.am

Also, why are .so.* and onig-config not installed when using the github
sources?

Could you also please confirm this change passes QA (portlint, poudriere)

-- 
You are receiving this mail because:
You are the assignee for the bug.