From owner-svn-src-head@FreeBSD.ORG  Fri Jun  1 05:14:38 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 18F9D1067FE9;
	Fri,  1 Jun 2012 05:13:57 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from mail16.syd.optusnet.com.au (mail16.syd.optusnet.com.au
	[211.29.132.197])
	by mx1.freebsd.org (Postfix) with ESMTP id 0E8868FC0C;
	Fri,  1 Jun 2012 05:13:56 +0000 (UTC)
Received: from c122-106-171-232.carlnfd1.nsw.optusnet.com.au
	(c122-106-171-232.carlnfd1.nsw.optusnet.com.au [122.106.171.232])
	by mail16.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	q515DmrV001102
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Fri, 1 Jun 2012 15:13:49 +1000
Date: Fri, 1 Jun 2012 15:13:48 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Eitan Adler <eadler@FreeBSD.org>
In-Reply-To: <201206010423.q514NKtf083043@svn.freebsd.org>
Message-ID: <20120601150242.V1226@besplex.bde.org>
References: <201206010423.q514NKtf083043@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r236377 - head/sys/dev/vxge/vxgehal
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Jun 2012 05:14:38 -0000

On Fri, 1 Jun 2012, Eitan Adler wrote:

> Author: eadler
> Date: Fri Jun  1 04:23:20 2012
> New Revision: 236377
> URL: http://svn.freebsd.org/changeset/base/236377
>
> Log:
>  Fix warning generated by clang;
>  	warning: equality comparison with extraneous parentheses
>  	[-Wparentheses-equality]
>
>  Reported by:	arundel
>  Reviewed by:	gnn
>  Approved by:	cperciva
>  MFC after:	3 days
>
> Modified:
>  head/sys/dev/vxge/vxgehal/vxgehal-channel.h
>
> Modified: head/sys/dev/vxge/vxgehal/vxgehal-channel.h
> ==============================================================================
> --- head/sys/dev/vxge/vxgehal/vxgehal-channel.h	Fri Jun  1 03:59:08 2012	(r236376)
> +++ head/sys/dev/vxge/vxgehal/vxgehal-channel.h	Fri Jun  1 04:23:20 2012	(r236377)
> @@ -291,7 +291,7 @@ __hal_channel_dtr_restore(__hal_channel_
> 	else
> 		dtr_index = channel->reserve_index - 1;
>
> -	if ((channel->dtr_arr[dtr_index].dtr == dtrh)) {
> +	if ((channel->dtr_arr[dtr_index].dtr = dtrh) != NULL) {
>
> 		channel->reserve_index = dtr_index;
> 		channel->dtr_arr[dtr_index].state = VXGE_HAL_CHANNEL_DTR_FREE;
>

This seems to change a style by (excessive parentheses for a normal
equality test) into logic bug (assignment of dtrh instead of compariing
with it).

Bruce