Date: Tue, 14 Mar 2017 10:01:53 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Nikolai Lifanov <lifanov@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r435996 - in head: . security security/samhain security/samhain-client security/samhain-server security/samhain/files Message-ID: <47080d50-9885-f7a7-5ed8-1b9b553012e8@FreeBSD.org> In-Reply-To: <201703121707.v2CH7Ng5054672@repo.freebsd.org> References: <201703121707.v2CH7Ng5054672@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--XseXtbMhrrfHFNOrlapduJFTasQerneue
Content-Type: multipart/mixed; boundary="5PCtPCPQhNfNiXt2wgRmh2rfVpxtr4sKp";
protected-headers="v1"
From: Mathieu Arnold <mat@FreeBSD.org>
To: Nikolai Lifanov <lifanov@FreeBSD.org>, ports-committers@freebsd.org,
svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Message-ID: <47080d50-9885-f7a7-5ed8-1b9b553012e8@FreeBSD.org>
Subject: Re: svn commit: r435996 - in head: . security security/samhain
security/samhain-client security/samhain-server security/samhain/files
References: <201703121707.v2CH7Ng5054672@repo.freebsd.org>
In-Reply-To: <201703121707.v2CH7Ng5054672@repo.freebsd.org>
--5PCtPCPQhNfNiXt2wgRmh2rfVpxtr4sKp
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Le 12/03/2017 =C3=A0 18:07, Nikolai Lifanov a =C3=A9crit :
> +CONFIGURE_ARGS=3D --localstatedir=3D/var \
You can drop that, it is already added by default by the
_LATE_CONFIGURE_ARGS mechanism.
> +GNUPG_BUILD_DEPENDS=3D gpg:${PORTSDIR}/security/gnupg
We dropped adding PORTSDIR to the depends line about a year ago, please
do not add more.
> +PRELUDE_LIB_DEPENDS=3D prelude:${PORTSDIR}/security/libprelude
Same here.
> +pre-everything::
> +
> +.if !defined(WITH_CLIENT) && !defined(WITH_SERVER)
> + @${ECHO_MSG}
> + @${ECHO_MSG} "Building Samhain in standalone mode."
> + @${ECHO_MSG} "If you wish to enable networked mode, please hit CTRL-C=
"
> + @${ECHO_MSG} "now, and build samhain from the samhain-client and"
> + @${ECHO_MSG} "samhain-server ports."
> + @${ECHO_MSG}
> +.endif
> +
> +.if defined(WITH_CLIENT) && defined(WITH_SERVER)
> +IGNORE=3D can't build client and server at once
> +.endif
> +
> +.if ${PORT_OPTIONS:MKCHECK}
> + @${ECHO_MSG}
> + @${ECHO_MSG} "Building with kernel checking requires reading /dev/kme=
m"
> + @${ECHO_MSG} "and /dev/mem. If you're not building as root, please hi=
t"
> + @${ECHO_MSG} "Control-C and restart the build as root."
> + @${ECHO_MSG}
> +.endif
You should not put some other code right in the middle of a target, so
you should move the IGNORE after it.
> +post-install:
>
> +post-stage:
>
Don't use both post-install and post-stage, only use post-install.
--=20
Mathieu Arnold
--5PCtPCPQhNfNiXt2wgRmh2rfVpxtr4sKp--
--XseXtbMhrrfHFNOrlapduJFTasQerneue
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQJ8BAEBCgBmBQJYx7GDXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IDWMP/RFPN74wnYDXRPmm3+j9dN3X
ul9k5zFeqhOD3POs+YhJCXNt5tbDpJFNVfo1Mrwv4vMk5Dp3JZzSNN9ySYRHVzdE
FzqdEI2G3YiJsUfSLl8sr3qZJvM9aMiHkbR7ewh6/G3Pv1Pjfnhc/N4mpiXSEUQb
WzU+T3SF+PYqEsZJkrYmVha/SPHmwEQiEtBMAKgFY2+ziOmVcuyLgi/r9KsUbDo9
B/39eEd0dm04CFDL3rKUQo8j+iE6JIl4++Z9axvpq3tg+u9J01By32C9B0EjfyhR
KfFcwe/IuYIWUPSOVTAld2QBxDXQjEJ5kuU17uC0GSvu1roiYf9wj67FWQ24gAkC
IfburvdTe75yOK+MV4CGSBYUV5rdPetagZRgqZ88etmsz7t9sSwi2Muc9DdXDb1V
rLrk1AH2nQOi9iQ79tlg8aOsgjnZQaLPHW5G0RMFhM/v4y3Br7n7b/yeGakNNMsw
iFErnbI0Q9g2njX7erCTpYqsgW3YkBMyntQZNmg5i8x10Z0JbIRpECPG1d8zxm1X
UYgCnnHSWogapPKrLjWXCRHMIg0Uqlz3mmGxrkxvXcG9DYWYS05t4RLvTQNXpQLj
6o1dAWmpeyeYUhSPPq9xGGKYPd/X3YoervHI+b5yViMWaES6Nrhint55nzCoNF+u
w2BFFbSxOcVnoJKmv6rk
=kTOc
-----END PGP SIGNATURE-----
--XseXtbMhrrfHFNOrlapduJFTasQerneue--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47080d50-9885-f7a7-5ed8-1b9b553012e8>