From owner-freebsd-xen@freebsd.org  Thu May 24 15:13:01 2018
Return-Path: <owner-freebsd-xen@freebsd.org>
Delivered-To: freebsd-xen@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9307BEF44F8
 for <freebsd-xen@mailman.ysv.freebsd.org>;
 Thu, 24 May 2018 15:13:01 +0000 (UTC)
 (envelope-from prvs=6753c1084=roger.pau@citrix.com)
Received: from SMTP.EU.CITRIX.COM (smtp.eu.citrix.com [185.25.65.24])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "mail.citrix.com",
 Issuer "DigiCert SHA2 Secure Server CA" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id DCEBC71453;
 Thu, 24 May 2018 15:13:00 +0000 (UTC)
 (envelope-from prvs=6753c1084=roger.pau@citrix.com)
X-IronPort-AV: E=Sophos;i="5.49,436,1520899200"; d="scan'208";a="73660476"
Date: Thu, 24 May 2018 17:12:01 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Pratyush Yadav <pratyush@freebsd.org>
CC: FreeBSD-Xen <freebsd-xen@freebsd.org>
Subject: Re: Leftover code in gnttab.h?
Message-ID: <20180524151201.gtpey5wifislq3z2@MBP-de-Roger.citrite.net>
References: <CA+X=3TJ0OubDVenkjC0CQnv9Cqc64cdXzwbO=qY1ZSq3dLXG6Q@mail.gmail.com>
 <20180524140636.7vz2gjshqow6efwe@MBP-de-Roger.citrite.net>
 <CA+X=3TK3KzhhuV8Fte3w+Zm44F6as3KpdvUBF+deJuj9+S9yGA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CA+X=3TK3KzhhuV8Fte3w+Zm44F6as3KpdvUBF+deJuj9+S9yGA@mail.gmail.com>
User-Agent: NeoMutt/20180323
X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To
 AMSPEX02CL02.citrite.net (10.69.22.126)
X-BeenThere: freebsd-xen@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: Discussion of the freebsd port to xen - implementation and usage
 <freebsd-xen.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-xen>,
 <mailto:freebsd-xen-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-xen/>
List-Post: <mailto:freebsd-xen@freebsd.org>
List-Help: <mailto:freebsd-xen-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-xen>,
 <mailto:freebsd-xen-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 24 May 2018 15:13:01 -0000

On Thu, May 24, 2018 at 08:38:30PM +0530, Pratyush Yadav wrote:
> Hi,
> 
> On Thu, May 24, 2018 at 7:36 PM, Roger Pau Monné <roger.pau@citrix.com> wrote:
> > On Thu, May 24, 2018 at 05:53:02PM +0530, Pratyush Yadav wrote:
> >> Hi everyone,
> >>
> >> I was reading the Xen grant table code and I noticed that some code is
> >> wrapped in an #if 0. You can see it in sys/xen/gnttab.h:138. I have
> >> also attached the "commented out" part down below.
> >>
> >> Is it useful? Is it all right if I submit a patch that removes it?
> >
> > This are leftovers from when the code was imported from Linux AFAICT.
> > I guess the original committer thought that those functions would be
> > implemented, so the prototypes where left in place.
> >
> > If you give me a patch to remove them I'm happy to commit it.
> 
> How should I send you the patch? Should I send it through
> reviews.freebsd.org, GitHub pull request or just paste the patch in
> the email?

Let's use reviews.freebsd.org, so that you can get used to it.

Roger.