From owner-freebsd-ports@FreeBSD.ORG Mon Feb 2 10:39:27 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3AEBC16A4CE for ; Mon, 2 Feb 2004 10:39:27 -0800 (PST) Received: from rdsnet.ro (smtp.rdsnet.ro [62.231.74.130]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7AEBA43D3F for ; Mon, 2 Feb 2004 10:39:25 -0800 (PST) (envelope-from itetcu@apropo.ro) Received: (qmail 13467 invoked from network); 2 Feb 2004 18:37:41 -0000 Received: from unknown (HELO it.buh.cameradicommercio.ro) (81.196.25.19) by mail.rdsnet.ro with SMTP; 2 Feb 2004 18:37:41 -0000 Date: Mon, 2 Feb 2004 20:39:31 +0200 From: Ion-Mihai Tetcu To: ports@FreeBSD.ORG Message-Id: <20040202203931.4bd23361@it.buh.cameradicommercio.ro> X-Mailer: Sylpheed version 0.9.8claws (GTK+ 1.2.10; i386-portbld-freebsd5.2) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: WANT_PHP_WEB=yes and make fetch X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Feb 2004 18:39:27 -0000 Hi, There are some ports that set WANT_PHP_WEB=yes and includes lang/php4/bsd.php.mk. One example is www/smarty which has in its Makefile: [..] NO_BUILD= yes WANT_PHP_WEB= yes PKGMESSAGE= ${WRKDIR}/pkg-message MSG_SRC= ${FILESDIR}/pkg-message MSG_SUB= DATADIR=${DATADIR} LOCALBASE=${LOCALBASE} .include .include "${PORTSDIR}/lang/php4/bsd.php.mk" do-install: [..] As a result, bsd.php.mk checks for mod_php and returns false on fetch target if the machine doesn't have PHP_MOD/PHP_CLI (and outputs an explanation message). The way I see it, fetch should mean only fetch (e.g. downloading the distfile(s)) and not checking anything else. The checking should be done after fetching. Moving the inclusion of bsd.php.mk, e.g.: [..] NO_BUILD= yes WANT_PHP_WEB= yes PKGMESSAGE= ${WRKDIR}/pkg-message MSG_SRC= ${FILESDIR}/pkg-message MSG_SUB= DATADIR=${DATADIR} LOCALBASE=${LOCALBASE} .include .post-fetch: .include "${PORTSDIR}/lang/php4/bsd.php.mk" do-install: [..] unbreaks fetching (at least for some of them on which I've tested). Am I missing anything here or could I prepare a patch ? The above could be extended to a lot of other ports that check for various things on the fetch target, but fetching "per se" doesn't need those {depends, OS_VERSION, etc.}. The goal would be to help people like myself, that need to have the distfiles fetched and on-hand in some "local" repository, because of bandwidth problems on some machines, etc. -- IOnut Unregistered ;) FreeBSD user