From owner-svn-src-all@FreeBSD.ORG Sun Feb 3 10:23:29 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 0345E938; Sun, 3 Feb 2013 10:23:29 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id AC75DD2; Sun, 3 Feb 2013 10:23:27 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id MAA07096; Sun, 03 Feb 2013 12:23:26 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1U1wjN-0006CQ-Sm; Sun, 03 Feb 2013 12:23:25 +0200 Message-ID: <510E3A9D.7040005@FreeBSD.org> Date: Sun, 03 Feb 2013 12:23:25 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130121 Thunderbird/17.0.2 MIME-Version: 1.0 To: Alexey Dokuchaev Subject: Re: svn commit: r246251 - head/sys/dev/acpica References: <201302021244.r12CiKgj046079@svn.freebsd.org> <20130202125122.GA4975@FreeBSD.org> <20130202151137.GA28366@FreeBSD.org> In-Reply-To: <20130202151137.GA28366@FreeBSD.org> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Feb 2013 10:23:29 -0000 on 02/02/2013 17:11 Alexey Dokuchaev said the following: > On Sat, Feb 02, 2013 at 12:51:22PM +0000, Alexey Dokuchaev wrote: >> On Sat, Feb 02, 2013 at 12:44:20PM +0000, Andriy Gapon wrote: >>> New Revision: 246251 >>> URL: http://svnweb.freebsd.org/changeset/base/246251 >>> >>> Log: >>> acpi: clear power button status bit after waking up... >>> so that it is not confused for a new power off request. >> >> Hmm, I was annoyed by this bug for a while. Will try to test it with >> 8-stable tonight, thanks! > > Andriy, it appears to me that ACPI code is substantially different between > 8-stable and head, so the patch cannot be applied as is. I'm not sure where > exactly inside acpi_EnterSleepState() does it belong. Could you provide me > with some guidance (or even patch for 8-stable)? Thanks. Yes, this is unfortunately so. It seems that some fellow developers who hack on ACPI-related code prefer to not MFC at all. I am not ready yet to provide a stable/8 patch and may give up on MFC to stable/8 altogether. P.S. logically the new block of code seems to belong to acpi_sleep_machdep() before intr_restore() call. -- Andriy Gapon