From owner-svn-ports-all@FreeBSD.ORG  Tue Sep 16 10:21:34 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from ptrcrt.ch (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 004AE6D2;
 Tue, 16 Sep 2014 10:21:32 +0000 (UTC)
Date: Tue, 16 Sep 2014 10:21:30 +0000
From: Pietro Cerutti <gahr@FreeBSD.org>
To: Adam Weinberger <adamw@FreeBSD.org>
Subject: Re: svn commit: r368030 - head/graphics/libosmesa
Message-ID: <20140916102130.GL23009@ptrcrt.ch>
Reply-To: gahr@FreeBSD.org
References: <201409121516.s8CFGo8I093324@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="08ATZu8fEq0x2T3M"
Content-Disposition: inline
In-Reply-To: <201409121516.s8CFGo8I093324@svn.freebsd.org>
X-PGP-Key: fp="DA6D E106 A5B8 54B8 5DD8  6D49 ADD0 D38E A192 089E";
 id="0xA192089E";
 get=<hkp://pgp.mit.edu/pks/lookup?search=0xADD0D38EA192089E&op=get>;
 get=<https://keyserver.pgp.com/vkd/DownloadKey.event?keyid=0xADD0D38EA192089E>;
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Sep 2014 10:21:34 -0000


--08ATZu8fEq0x2T3M
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2014-Sep-12, 15:16, Adam Weinberger wrote:
> Author: adamw
> Date: Fri Sep 12 15:16:49 2014
> New Revision: 368030
> URL: http://svnweb.freebsd.org/changeset/ports/368030
> QAT: https://qat.redports.org/buildarchive/r368030/
>=20
> Log:
>   Fix build by depending on bison.
>  =20
>     GEN      program/program_parse.tab.c
>   byacc: e - line 119 of "program/program_parse.y", syntax error
>   %locations
>   ^
>   gmake[3]: *** [program/program_parse.tab.c] Error 1
>=20
> Modified:
>   head/graphics/libosmesa/Makefile
>=20
> Modified: head/graphics/libosmesa/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/graphics/libosmesa/Makefile	Fri Sep 12 15:04:27 2014	(r368029)
> +++ head/graphics/libosmesa/Makefile	Fri Sep 12 15:16:49 2014	(r368030)
> @@ -13,7 +13,7 @@ COMMENT=3D	Off-Screen Mesa implementation=20
>  LIB_DEPENDS=3D	libexpat.so:${PORTSDIR}/textproc/expat2
>  BUILD_DEPENDS=3D	${PYTHON_SITELIBDIR}/libxml2mod.so:${PORTSDIR}/textproc=
/py-libxml2
> =20
> -USES=3D		gmake pkgconfig tar:bzip2 libtool python:2
> +USES=3D		gmake pkgconfig tar:bzip2 libtool python:2 bison
>  USE_LDCONFIG=3D	yes
>  GNU_CONFIGURE=3D	yes
>  CONFIGURE_ARGS+=3D--enable-osmesa \

Just bringing in a dependency on bison doesn't fix the problem. See what
I've checked in as r368300. Moreover, some pre-commit notification on
this would have been appreciated.

--=20
Pietro Cerutti
The FreeBSD Project
gahr@FreeBSD.org

PGP Public Key:
http://gahr.ch/pgp

--08ATZu8fEq0x2T3M
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQJ8BAEBCgBmBQJUGA8qXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQTZERTEwNkE1Qjg1NEI4NUREODZENDlB
REQwRDM4RUExOTIwODlFAAoJEK3Q046hkgieurgP/RsOjz8P2YBGsfN66d9S0dMy
Adg0an4tad4B2s/cUo9ACdkMW3ChC1ZnZ3ow4JsvpCxKEyVLgEgOl3EmRr/OakHx
eYzMq2Qmhkha6n/uC5UOIHd6l4zq5rNr0EP88Mw4SlvQ65421rLXCRL1Oill5b03
VWasvgHLOxsmADi2D9UKOsLC2YHKibPg4uQF6Z5cectOvaXr71zIpV4yT05CgGmM
ZuFFald0tU+hcgpRFw+bUDBoiYLRay+oyZNJpyYnE/dHtmjprNp3LBE2wyykh7y6
8FrN5KZYK4h/mVaIkg/J6PAUii6fUh8lxpAYmGB5inTo6RJF3Fpj/ECHk//eLgeC
1UlfSYTT5+iekA9EPYAbXn9SOEHfKjgadMcIWDr4sEX0KkEjY2rP4mMAoPc57ayE
Q6vNSludOwH7IEGjBqOdOcmLjVyekyp9+4xEiq6wujKQwTN4ESo6dY0txhLd6cZX
MLD6fPP0Bj3fIqZKpxe+dxubu4qj0D8GzzsABuPqbMZqgl8jZVUvG/1Igt5/THoF
binoL/WOviGnxNApowJY/RSpLP83b/uWKVyLup3VuKCF3ab8ZwdXtuci7IoDEKcx
7pTgfWRoBrrvXPg2VhsjvB2VoezGmbWaNJStB9asVpglmQCH1fnER3/D130WRcvr
BL2h+cGh5QBzlGK6A34U
=hvTt
-----END PGP SIGNATURE-----

--08ATZu8fEq0x2T3M--