From owner-svn-src-head@FreeBSD.ORG Thu Mar 5 04:04:04 2009 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F3FE6106564A; Thu, 5 Mar 2009 04:04:03 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id ABFB98FC18; Thu, 5 Mar 2009 04:04:03 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id n25434Sw095653; Wed, 4 Mar 2009 21:03:04 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Wed, 04 Mar 2009 21:03:22 -0700 (MST) Message-Id: <20090304.210322.1353606728.imp@bsdimp.com> To: rnoland@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <1236224629.1384.22.camel@widget.2hip.net> References: <1236218572.1384.19.camel@widget.2hip.net> <20090304.194158.1159134197.imp@bsdimp.com> <1236224629.1384.22.camel@widget.2hip.net> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r189367 - head/sys/dev/pci X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Mar 2009 04:04:04 -0000 In message: <1236224629.1384.22.camel@widget.2hip.net> Robert Noland writes: : On Wed, 2009-03-04 at 19:41 -0700, M. Warner Losh wrote: : > In message: <1236218572.1384.19.camel@widget.2hip.net> : > Robert Noland writes: : > : On Wed, 2009-03-04 at 13:56 -0700, M. Warner Losh wrote: : > : > In message: <200903041823.n24INmcc049524@svn.freebsd.org> : > : > Robert Noland writes: : > : > : Author: rnoland : > : > : Date: Wed Mar 4 18:23:48 2009 : > : > : New Revision: 189367 : > : > : URL: http://svn.freebsd.org/changeset/base/189367 : > : > : : > : > : Log: : > : > : Extend the management of PCIM_CMD_INTxDIS. : > : > : : > : > : We now explicitly enable INTx during bus_setup_intr() if it is needed. : > : > : Several of the ata drivers were managing this bit internally. This is : > : > : better handled in pci and it should work for all drivers now. : > : > : : > : > : We also mask INTx during bus_teardown_intr() by setting this bit. : > : > : : > : > : Reviewed by: jhb : > : > : MFC after: 3 days : > : > : > : > Note: the INTxDIS bit is new in PCI 3.0, and has no effect on earlier : > : > devices. This should be highlighted in the comments somewhere... : > : : > : It is documented in 2.3 as well, I'm not sure about previous versions of : > : the spec though. : > : > It isn't in 2.2, and even after 2.3 it is "optional". : : The bit should be unused if it isn't supported by a given piece of : hardware. If it doesn't do anything, we are no worse off than before. : I don't think this will cause any harm, only goodness when it is : supported. Yes. I agree. This is just the sort of bit, however, that people looking for an interrupt storm would latch on to as being just the ticket... Which is why I suggested a comment... Warner