From owner-dev-commits-src-main@freebsd.org Wed Apr 14 19:39:08 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6168F5E5D8D for ; Wed, 14 Apr 2021 19:39:08 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FLCTS22w6z3tkv for ; Wed, 14 Apr 2021 19:39:08 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qv1-xf2a.google.com with SMTP id er3so2005033qvb.6 for ; Wed, 14 Apr 2021 12:39:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZeeRfalnoC9uX0ZwcAEq6Hlpw18R/HzsjbfUvwxSzSI=; b=lI8hlTdLroktvnmwhoe1RdzTf8h08wLmKmEi02zpUi8HHz68DZWEZl/tkSApIUwmzd wnQ4WItzW1MQtjJYIkjFHgp97tsNQFOMFzZpvwwYCW4kdW9Yxcv+2GS7CY4VqTo0wY4H wWhn0xPDdv88aHW2d8+ttUGqhgPXjhPGVzZnfMMDi14CiN7icCmjS2itMg3ZbHduZKAc xrlqenqnWHmdPTcCS+2c3MwQ5YQVZduy0mgs2nm3vhdEdcO5guhaQQLUOMrc19+U3DNY wWmQY8N3YTuNz/A2bc5rwffz8+RmV8rOdiLSmkjvojZaCiTJZ9zprRpCHzWKsf0/w8Ah g8eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZeeRfalnoC9uX0ZwcAEq6Hlpw18R/HzsjbfUvwxSzSI=; b=BC//7xGsvHhUNxDuq96Q9VXxTJQyp4DtrgIr571Y1f9HRbYyt+QTZdcr+Ph9GbZkXn GLnVmzS6jXIiTcG/VQ/7vGWNHWJhDi9M491XqcX3HxMDDwCkXQbGTRELl29h3ynadY/G B+tfOrlW3RY2s5IEoD/0lsrew974kwK/DsdLHFRyovaKNvnSiijHdK3LMPusoa8W/3QM PY+HOIv54e+zAIo/8NYHettmOjSgWvqswfsq4PqLtAAguHy44x/j2dhCWMhXtQqSzQEa OCYt5yJhouO/qhUisFIDMdBs3ZCKDrlAGAV8ZepmcZtajDELj50LFu8UfXZJkK378Afl DINA== X-Gm-Message-State: AOAM531H+M0GV8U6jr8c51egqVsBq+zyQJwyqefQABSrnWzEcWGT6GlI zs3qwChcK25oRWHgWUX1NdouKygz+LRs+x6mB3tZwA== X-Google-Smtp-Source: ABdhPJzoPP0rcucwKB2ndWB5OFANiggiDv0JWOTd42kdyK/1Pir7AdO+9ZxdDCk+FrbNnvaErjOnDmWdr7q295B/I/w= X-Received: by 2002:a05:6214:1866:: with SMTP id eh6mr1022483qvb.29.1618429147227; Wed, 14 Apr 2021 12:39:07 -0700 (PDT) MIME-Version: 1.0 References: <202104141038.13EAcgMl042607@gndrsh.dnsmgr.net> In-Reply-To: <202104141038.13EAcgMl042607@gndrsh.dnsmgr.net> From: Warner Losh Date: Wed, 14 Apr 2021 13:38:56 -0600 Message-ID: Subject: Re: git: e6ab1e365c06 - main - config(8): Correct the mentioned paper in the SEE ALSO section To: "Rodney W. Grimes" Cc: Gordon Bergling , src-committers , "" , dev-commits-src-main@freebsd.org X-Rspamd-Queue-Id: 4FLCTS22w6z3tkv X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Apr 2021 19:39:08 -0000 On Wed, Apr 14, 2021 at 4:38 AM Rodney W. Grimes wrote: > > On Tue, Apr 13, 2021 at 03:41:22AM -0700, Rodney W. Grimes wrote: > > > > The branch main has been updated by gbe (doc committer): > > > > > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=e6ab1e365c06559e964667d2f5a6de856fa28be6 > > > > > > > > commit e6ab1e365c06559e964667d2f5a6de856fa28be6 > > > > Author: Gordon Bergling > > > > AuthorDate: 2021-04-13 04:49:00 +0000 > > > > Commit: Gordon Bergling > > > > CommitDate: 2021-04-13 04:49:00 +0000 > > > > > > > > config(8): Correct the mentioned paper in the SEE ALSO section > > > > > > > > FreeBSD's version of the config(8) utility is based on 4.3BSD not > > > > 4.4BSD. So correct the mentioned paper in the SEE ALSO section. > > > > > > What is this based upon? > > > > > > As far as I know, and I am the one that did the imports, we > > > never had the source code to config(8) for 4.3BSD, the config > > > sources in the system are imported from the 4.4BSD lite source tape. > > > > Warner has sent me a private mail in which he told me that FreeBSD's > > config(8) is based on 4.3BSD with a lot modifications. The updated > > paper date and origin I got from a scan of the original documents > > found at [1]. > > If this has infact occured that is a violation of the AT&T/USL > lawsuit agreement. > > Further as the person that did the import of 4.4, and did the lifting > to make that version work with FreeBSD I dispute this claim that > the config utility is based on 4.3BSD, the history of the files simply > do not bear that to be true. > > Please revert this inaccurate change of history. > There were two different config programs in 4.4BSD, which is the base of this confusion. Rodney imported "config" from the 4.4-Lite tapes. This is the older one, based on the 4.3BSD config with i386 added (he did nothing wrong here: it was config on 4.4BSD). In talking about this with $OTHERBSD projects this has always been referred to as the 4.3BSD-based config, even if that's a bit inaccurate. It was referred to this way because they'd adopted config.new from 4.4BSD and considered that the 4.4BSD-based config.... Chris Torek wrote config.new, which also first appeared on the 4.4BSD tape, and subsequent 4.4BSD-lite releases. NetBSD adopted this in its early days, so it's the basis for both NetBSD and OpenBSD. There was even a port to FreeBSD which lost out to Doug Rabson's newbus for device configuration in the FreeBSD 3.x timeframe. Atsushi Furuta-san presented on this port at USENIX-99, the paper can be found here: https://www.usenix.org/legacy/event/usenix99/full_papers/furuta/furuta.pdf and Chris Torek's original paper is available from here: http://www.netbsd.org/Documentation/kernel/config-torek.ps I'd only ever seen his paper (at least I think it's this paper, since my mac can't render it for me to confirm). It describes config.new, but bills it as the configuration for 4.4BSD systems. I read it years ago. My failure was that I'd neglected to double check what was actually in the 4.4BSD manual. I'd assumed it was Chris' paper, but a check now shows that I was wrong. So Rodney is right, this should have been reverted. Warner > Regards, > Rod > > > > --Gordon > > > > [1] http://www.bitsavers.org/pdf/mtXinu/MT_XINU_SMM_Apr_1986.pdf > > > > > > Reported by: imp > > > > Reviewed by: imp > > > > X-MFC-with: 2b59392cb0da804e825c63469beb1934ec4267db > > > > Differential Revision: https://reviews.freebsd.org/D29701 > > > > --- > > > > usr.sbin/config/config.8 | 7 ++++--- > > > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/usr.sbin/config/config.8 b/usr.sbin/config/config.8 > > > > index 929607712ef8..1e874c3e8355 100644 > > > > --- a/usr.sbin/config/config.8 > > > > +++ b/usr.sbin/config/config.8 > > > > @@ -28,7 +28,7 @@ > > > > .\" @(#)config.8 8.2 (Berkeley) 4/19/94 > > > > .\" $FreeBSD$ > > > > .\" > > > > -.Dd April 9, 2021 > > > > +.Dd April 11, 2021 > > > > .Dt CONFIG 8 > > > > .Os > > > > .Sh NAME > > > > @@ -249,11 +249,12 @@ The > > > > .Sx SYNOPSIS > > > > portion of each device in section 4. > > > > .Rs > > > > -.\" 4.4BSD SMM:2 > > > > +.\" 4.3BSD SMM:2 > > > > .%A S. J. Leffler > > > > .%A M. J. Karels > > > > .%T "Building 4.3 BSD UNIX System with Config" > > > > -.%B 4.4BSD System Manager's Manual (SMM) > > > > +.%B 4.3BSD System Manager's Manual (SMM) > > > > +.%D June 3, 1986 > > > > .Re > > > > .Sh HISTORY > > > > The > > > > > > > > > > -- > > > Rod Grimes > rgrimes@freebsd.org > > > > -- > > > > -- > Rod Grimes > rgrimes@freebsd.org >