From owner-cvs-all Tue Apr 9 18:16:50 2002 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (gw.Awfulhak.org [217.204.245.18]) by hub.freebsd.org (Postfix) with ESMTP id 34E1F37B405; Tue, 9 Apr 2002 18:16:38 -0700 (PDT) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [IPv6:fec0::1:12]) by Awfulhak.org (8.12.2/8.11.6) with ESMTP id g3A1Gaoi027302; Wed, 10 Apr 2002 02:16:36 +0100 (BST) (envelope-from brian@freebsd-services.com) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.12.2/8.12.2) with ESMTP id g3A1GZOF004892; Wed, 10 Apr 2002 02:16:35 +0100 (BST) (envelope-from brian@freebsd-services.com) Message-Id: <200204100116.g3A1GZOF004892@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Brian Somers Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@freebsd-services.com Subject: Re: cvs commit: src/sys/kern kern_linker.c In-Reply-To: Message from Brian Somers of "Tue, 09 Apr 2002 18:14:45 PDT." <200204100114.g3A1Ejb02730@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 10 Apr 2002 02:16:35 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > brian 2002/04/09 18:14:45 PDT > > Modified files: > sys/kern kern_linker.c > Log: > In linker_load_module(), check that rootdev != NODEV before calling > linker_search_module(). > > Without this, modules loaded from loader.conf that then try to load > in additional modules (such as digi.ko loading a card's BIOS) die > badly in the vn_open() called from linker_search_module(). > > It may be worth checking (KASSERTing?) that rootdev != NODEV in > vn_open() too. > > Revision Changes Path > 1.88 +5 -3 src/sys/kern/kern_linker.c After these changes, it's possible for digi to find it's BIOS/FEPOS from one of the digi_* modules at boot time - as long as that digi_* module is already available (either built into the kernel or ``loaded'' at boot time). However, digi fails to initialise the card - I think due to tsleep failing... but I'm not sure yet. -- Brian http://www.freebsd-services.com/ Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message