From owner-freebsd-ports@FreeBSD.ORG Mon Sep 15 04:12:09 2008 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CE698106566B for ; Mon, 15 Sep 2008 04:12:09 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.251]) by mx1.freebsd.org (Postfix) with ESMTP id 811D38FC0A for ; Mon, 15 Sep 2008 04:12:09 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: by an-out-0708.google.com with SMTP id b33so189977ana.13 for ; Sun, 14 Sep 2008 21:12:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=6NxJlWF50rRNJ8JKzDpcF3AgTb0Q06sDHGqnzCRRSFA=; b=cgIC87nb6eXRQWocR78NFTUDSzmMq1a9E8Gf7pNX2lmQB1RsZ6sCmnUuzf5rbinv22 Cqt2oH6kc6X7VTn3vmUYdtjzxipAb85t6r1hwQv4dHsUaVBkK11w3CvX1HPcVAoeV0qJ B4rCHTdLlxcza/CideDU2lkfFjcDBMVcbp2l4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=AgZ1HlSGAcxifKDhBJyrIJvV9k9uc1j6LcXkurj0DY0QK9Zv42/ceobJFrxJJO9t/x i18U+J752Uouoc9crdcUZBfWXvw8d2RcuN4O/tE/aOhpUXnbo/xKAs2gmWqfdmmKF3KC jzkxTR297+AYhCN/niLgVuYUA9F/b+/+0NZm0= Received: by 10.86.82.6 with SMTP id f6mr5525159fgb.73.1221451927691; Sun, 14 Sep 2008 21:12:07 -0700 (PDT) Received: by 10.86.62.14 with HTTP; Sun, 14 Sep 2008 21:12:07 -0700 (PDT) Message-ID: <7d6fde3d0809142112o4de36352md0302b4d8608b03f@mail.gmail.com> Date: Sun, 14 Sep 2008 21:12:07 -0700 From: "Garrett Cooper" To: "FreeBSD Ports" , current@freebsd.org In-Reply-To: <7d6fde3d0809142110x1d28e40fm4e976f93ae507852@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200807241348.m6ODmVNe090621@www.freebsd.org> <7d6fde3d0807241118x122c25dbjad0e6f7b98f789d7@mail.gmail.com> <20080909212343.58886989@tau.draftnet> <7d6fde3d0809112324l5d99c157n1d5f23efbb32f3bf@mail.gmail.com> <7d6fde3d0809142110x1d28e40fm4e976f93ae507852@mail.gmail.com> Cc: Subject: Fwd: bin/125932: pkg_add(1) doesn't prompt for root credentials and then fails badly X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Sep 2008 04:12:09 -0000 ------------------------ Fyi (From Bugbuster email for bin/125932): ------------------------ Here's a proposed patch for the first set of cleanup to pkg_install: , and some fixing to alleviate the issue in bin/125932. Rather than biting off more than I can chew with the perforce project, I'm going to work off the changes Anders has made and incrementally polish pkg_install (like I should have done last year -_-...) This patch causes pkg_install to error out at the first sign of install failure (which could take a while as it's still using tar(1) to extract archives in add/extract.c), BUT in getFileByURL I've completely replaced the tar requirement in lib/url.c with archive(3)'s, quite handy hooks for writing to files. So don't be alarmed when you see that the file has grown 4 times ;)... This patch hasn't gotten much mileage, other than a few failure and success cases, so if others could please take a look at this and provide comments I'd much appreciate it. Cheers, -Garrett PS Packages might not be dumped in the correct spot -- I just chose /var/tmp, but if someone could point me to the "industry standard" location that portupgrade uses for instance, I'd be more than happy to point there.