Date: Mon, 12 Aug 2019 10:47:18 -0700 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Carlos Jacobo Puga Medina <cjpm@gmx.es>, Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r508723 - head/net/ocserv Message-ID: <9A853940-2D7C-4EA8-999E-AE0F81A90102@cschubert.com> In-Reply-To: <trinity-7cce5a4c-b382-44b9-99bd-64f53b5fe7cc-1565630462601@3c-app-mailcom-bs15> References: <201908121052.x7CAq001072686@repo.freebsd.org> <20190812135241.GA26036@FreeBSD.org> <trinity-7cce5a4c-b382-44b9-99bd-64f53b5fe7cc-1565630462601@3c-app-mailcom-bs15>
next in thread | previous in thread | raw e-mail | index | archive | help
On August 12, 2019 10:21:02 AM PDT, Carlos Jacobo Puga Medina <cjpm@gmx=2Ee= s> wrote: > > >-- >Carlos Jacobo Puga Medina <cjpm@gmx=2Ees> > > >> Enviar: lunes 12 de agosto de 2019 a las 15:52 >> De: "Alexey Dokuchaev" <danfe@freebsd=2Eorg> >> Para: "Carlos J=2E Puga Medina" <cpm@freebsd=2Eorg> >> CC: ports-committers@freebsd=2Eorg, svn-ports-all@freebsd=2Eorg, >svn-ports-head@freebsd=2Eorg >> Asunto: Re: svn commit: r508723 - head/net/ocserv >> >> On Mon, Aug 12, 2019 at 10:52:00AM +0000, Carlos J=2E Puga Medina >wrote: >> > New Revision: 508723 >> > URL: https://svnweb=2Efreebsd=2Eorg/changeset/ports/508723 >> > >> > Log: >> > net/ocserv: Fix typos in pkg-descr >> > >> > PR: 239577 >> > Submitted by: Mikael Urankar <mikael=2Eurankar@gmail=2Ecom> >> > >> > Modified: head/net/ocserv/pkg-descr >> > >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> > --- head/net/ocserv/pkg-descr Mon Aug 12 10:39:48 2019 (r508722) >> > +++ head/net/ocserv/pkg-descr Mon Aug 12 10:52:00 2019 (r508723) >> > @@ -6,9 +6,9 @@ The OpenConnect protocol provides a dual TCP/UDP >VPN c >> > uses the standard IETF security protocols to secure it=2E Both IPv4 >> > and IPv6 are supported=2E >> > >> > -Ocserv's main features are security through provilege separation >> > +Ocserv's main features are security through privilege separation >> > and sandboxing, accounting, and resilience due to a combined use >> > -of TCP and UDP=2E Authentication occurs in an isolated security >> > +of TCP and UDP=2E Authentication occurs in an isolated security >> >> This was not a typo, plain text generally looks better with double >> spaces after full stop; it might not be as popular in other places/ >> traditions as it is in US, but FreeBSD typically adheres to Americal >> spelling and formatting rules=2E >> >> Regardless of one's personal preference, touching the line merely to >> change the amount of whitespace between sentences is gratuitous (part >> of the) commmit and should've been avoided=2E >> > >Thanks for the explanation=2E In fact, if you strongly disagree, please >do not hesitate to revert the commit=2E > >> =2E/danfe >> >> Personally, I prefer to keep style and formatting changes separate from f= unctional changes=2E This is especially relevant for base but IMO also rele= vant for ports=2E Months or years from now when bisecting a revision, it is= easier to review only a functional change than to have to work through a c= hange polluted by gratuitous formatting changes=2E Consider the poor soul w= ho's trying to figure out what was done long after a commit=2E Either don't= reformat or reformat in a separate commit=2E Pet portlint separately too= =2E It also makes bisecting more time consuming=2E --=20 Pardon the typos and autocorrect, small keyboard in use=2E Cheers, Cy Schubert <Cy=2ESchubert@cschubert=2Ecom> FreeBSD UNIX: <cy@FreeBSD=2Eorg> Web: http://www=2EFreeBSD=2Eorg The need of the many outweighs the greed of the few=2E
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9A853940-2D7C-4EA8-999E-AE0F81A90102>