From owner-freebsd-bugs Sat Sep 7 12:48:42 2002 Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9F4D637B40E; Sat, 7 Sep 2002 12:48:29 -0700 (PDT) Received: from rwcrmhc52.attbi.com (rwcrmhc52.attbi.com [216.148.227.88]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3922343E4A; Sat, 7 Sep 2002 12:48:28 -0700 (PDT) (envelope-from bmah@employees.org) Received: from bmah.dyndns.org ([12.233.149.189]) by rwcrmhc52.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020907194818.CEQD14182.rwcrmhc52.attbi.com@bmah.dyndns.org>; Sat, 7 Sep 2002 19:48:18 +0000 Received: from intruder.bmah.org (localhost [IPv6:::1]) by bmah.dyndns.org (8.12.6/8.12.6) with ESMTP id g87JmIsU022525; Sat, 7 Sep 2002 12:48:18 -0700 (PDT) (envelope-from bmah@intruder.bmah.org) Received: (from bmah@localhost) by intruder.bmah.org (8.12.6/8.12.6/Submit) id g87JmI5v022524; Sat, 7 Sep 2002 12:48:18 -0700 (PDT) Message-Id: <200209071948.g87JmI5v022524@intruder.bmah.org> X-Mailer: exmh version 2.5+ 20020729 with nmh-1.0.4 To: Dan Lukes Cc: "Bruce A. Mah" , freebsd-bugs@FreeBSD.org, freebsd-gnats-submit@FreeBSD.org Subject: Re: bin/42384: MDXFileChunk may return 0 instead of hash In-Reply-To: <3D7A5400.1010002@obluda.cz> References: <200209071611.g87GBolU030973@freefall.freebsd.org> <3D7A5400.1010002@obluda.cz> Comments: In-reply-to Dan Lukes message dated "Sat, 07 Sep 2002 21:31:12 +0200." From: bmah@FreeBSD.org (Bruce A. Mah) Reply-To: bmah@FreeBSD.org X-Face: g~c`.{#4q0"(V*b#g[i~rXgm*w;:nMfz%_RZLma)UgGN&=j`5vXoU^@n5v4:OO)c["!w)nD/!!~e4Sj7LiT'6*wZ83454H""lb{CC%T37O!!'S$S&D}sem7I[A 2V%N&+ X-Image-Url: http://www.employees.org/~bmah/Images/bmah-cisco-small.gif X-Url: http://www.employees.org/~bmah/ Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_-1212473703P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Sat, 07 Sep 2002 12:48:17 -0700 Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org --==_Exmh_-1212473703P Content-Type: text/plain; charset=us-ascii If memory serves me right, Dan Lukes wrote: > Yes, your patch works, but ... > > With full respect to fact you are commiter, so final decision is your > suverenity - can you think about revoking your's straightforward fix a > commiting my (more performance friendly) one ? Hi Dan-- Initializing this variable once per invocation of this function is going to be insignificant compared to the time that it takes to run an MD5 computation. Cheers, Bruce. --==_Exmh_-1212473703P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) Comment: Exmh version 2.5+ 20020506 iD8DBQE9elgB2MoxcVugUsMRAqvBAKDTHaAkmranMyCVBloZpEzmvIPJqwCeJeyZ 2XAf+TksutnR0Fc28UKWoRA= =e2dY -----END PGP SIGNATURE----- --==_Exmh_-1212473703P-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message