Date: Sat, 07 Sep 2002 12:48:17 -0700 From: bmah@FreeBSD.org (Bruce A. Mah) To: Dan Lukes <dan@obluda.cz> Cc: "Bruce A. Mah" <bmah@FreeBSD.org>, freebsd-bugs@FreeBSD.org, freebsd-gnats-submit@FreeBSD.org Subject: Re: bin/42384: MDXFileChunk may return 0 instead of hash Message-ID: <200209071948.g87JmI5v022524@intruder.bmah.org> In-Reply-To: <3D7A5400.1010002@obluda.cz> References: <200209071611.g87GBolU030973@freefall.freebsd.org> <3D7A5400.1010002@obluda.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
--==_Exmh_-1212473703P Content-Type: text/plain; charset=us-ascii If memory serves me right, Dan Lukes wrote: > Yes, your patch works, but ... > > With full respect to fact you are commiter, so final decision is your > suverenity - can you think about revoking your's straightforward fix a > commiting my (more performance friendly) one ? Hi Dan-- Initializing this variable once per invocation of this function is going to be insignificant compared to the time that it takes to run an MD5 computation. Cheers, Bruce. --==_Exmh_-1212473703P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) Comment: Exmh version 2.5+ 20020506 iD8DBQE9elgB2MoxcVugUsMRAqvBAKDTHaAkmranMyCVBloZpEzmvIPJqwCeJeyZ 2XAf+TksutnR0Fc28UKWoRA= =e2dY -----END PGP SIGNATURE----- --==_Exmh_-1212473703P-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200209071948.g87JmI5v022524>