From owner-freebsd-current@FreeBSD.ORG Sun Jan 22 21:59:20 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 767A616A41F; Sun, 22 Jan 2006 21:59:20 +0000 (GMT) (envelope-from dunstan@zsno.ids.czest.pl) Received: from zsno.ids.czest.pl (zsno.ids.czest.pl [212.87.237.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id B54E943D49; Sun, 22 Jan 2006 21:59:18 +0000 (GMT) (envelope-from dunstan@zsno.ids.czest.pl) Received: from zsno.ids.czest.pl (localhost [127.0.0.1]) by zsno.ids.czest.pl (8.13.4/8.13.3) with ESMTP id k0MNd7Bt087892 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 23 Jan 2006 00:39:07 +0100 (CET) (envelope-from dunstan@zsno.ids.czest.pl) Received: (from dunstan@localhost) by zsno.ids.czest.pl (8.13.4/8.13.3/Submit) id k0MNd6EL087891; Mon, 23 Jan 2006 00:39:06 +0100 (CET) (envelope-from dunstan) Date: Mon, 23 Jan 2006 00:39:06 +0100 From: "Wojciech A. Koszek" To: freebsd-current@freebsd.org Message-ID: <20060122233906.GA87779@zsno.ids.czest.pl> References: <20051221031526.31ABC290@mx2.synetsystems.com> <200512211111.44268.jhb@freebsd.org> <20051227173434.GA53513@FreeBSD.czest.pl> <20060101182227.GB17837@FreeBSD.czest.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline In-Reply-To: <20060101182227.GB17837@FreeBSD.czest.pl> User-Agent: Mutt/1.4.2.1i X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (zsno.ids.czest.pl [127.0.0.1]); Mon, 23 Jan 2006 00:39:07 +0100 (CET) X-Spam-Status: No, score=-2.8 required=4.0 tests=ALL_TRUSTED autolearn=ham version=3.0.4 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on zsno.ids.czest.pl X-Virus-Scanned: ClamAV version 0.87, clamav-milter version 0.87 on zsno.ids.czest.pl X-Virus-Status: Clean Cc: Richard Todd , rwatson@freebsd.org Subject: Re: Bug in latest rev kern_acct.c: panic: Trying sleep, but thread marked as sleeping prohibited X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Jan 2006 21:59:20 -0000 On Sun, Jan 01, 2006 at 06:22:27PM +0000, Wojciech A. Koszek wrote: > On Sat, Dec 31, 2005 at 06:39:31PM -0600, Richard Todd wrote: > > "Wojciech A. Koszek" writes: > > > > > On Wed, Dec 21, 2005 at 11:11:43AM -0500, John Baldwin wrote: > > >> acctwatch() probably isn't a good thing to do from a callout since it wants to > > >> do VOPs and such. Probably the easiest fix is to stick acctwatch() in its > > >> own kthread. > > > > > > I think I didn't break current behaviour. Patch is here: > > > > > > http://freebsd.czest.pl/dunstan/FreeBSD/kern_acct.0.patch > > > > > > Richard, could you try to repeat your problem with my patch? > > > > Got a chance to try a new kernel today with your patch. I tried to reproduce > > the panic by repeatedly copying a bunch of stuff onto /usr and deleting it > > in one window, and in another repeatedly doing "make configure; make clean" > > in one rather large port. Lots of "Accounting suspended/resumed" messages > > in the logs and no panics. So it's looking good from here. > > Thanks for testing this. I couldn't crash my box either. I belive that > KASSERT() before suspend/resume handling will always be true, just like > ACCT_ENABLED state. In the final version of the patch I'll include some > cosmetic changes suggested by Robert Watson (thanks!). (Sorry for late response. I'm having terrible problems with DNS server for freebsd.czest.pl. I'll try to get them fixed this week). Updated patch for accouting is here: http://zsno.ids.czest.pl/~dunstan/FreeBSD/kern_acct.2.patch -- * Wojciech A. Koszek &&