From nobody Tue Jun 17 16:53:56 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bMCd13cxqz5VbLY; Tue, 17 Jun 2025 16:53:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bMCd05x0Bz4J7Z; Tue, 17 Jun 2025 16:53:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1750179236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ANpIYJNAjjHRRID7LUROjBvMyBOcH19Q6kzGVEV6X7Q=; b=rmhq+jGPvHftKPe1ThOxEr4SEAaUp40q3+4pFAbNoIsteJqNOp6aA43HZEIQiJmUtlQ4P9 cEDXAa6kps6mGrC01VQudW3Sgl5aWqH2iVhsyhX0gsEGsGfhDMFztlC6GZoo4m025CbvO+ H/s+w70wSmR5+kmp+0sm/5BvTBfbxQHRd//oLY0rRD4JJD/whqMwxvSt4DJijhYrYlM+Gv z7PYQvaJP+V1LChjMD3ldHqlx7ez5KqX721HnTqrrYJz1yZvvzkowTCWR0HH3i11L2LafP tlMvokDx3qvQR6zd/hPHELTbA853HvWdmamM2qDjfCUQoGWi7neoqO314riixg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1750179236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ANpIYJNAjjHRRID7LUROjBvMyBOcH19Q6kzGVEV6X7Q=; b=lt5O+w+MOaj1Gs4mLTIyUkDhwMdY1do52EdACVabFY43P65AT8IdvLhn3iiActOHzlL+1S z5ElllEktGFMGifIoNORn1AOLKOvX6PpYQtbB9TtqOh77j7jnWmJzNXnlRDqvNm/Q4g8M1 myxnAs4CqTGNynvNOcDQ/enwq7cbLtA4UmgpDJ8KnYva0muULstFYjt9XyKO+MJbVmQC7A jbPm9n6ZyxHVgkGk7TFMZWbwWpySIgj5ZmNxuqSoJW4zDb4m8i1AU7Ma3mTBhl7d+MWiR0 ARl4JTupuwDwr6k7LC/v9Yn27gxsZM3n+uaVIWulblenpYhomQjRKSyz02Llyg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1750179236; a=rsa-sha256; cv=none; b=NeL4b+8yFL37PvDu+z7DchoWQRZjwaTI7N4wGpJNBglErhaDW3/NYnBT3cVOkad30wcA+S WX1zV5M5UwBfIUCGhWlkwmu0tgurkXawpCYx43/ak/rocZMIKrNwMiU+If0LWAdIH2G5KI /E+gGUIBhoWngEDG6qExZZWd/Qh2jpaj9y3LGIVaIdClLM2DBCkYSraCtqTWYncv/Yqbeb yt2XXjJylftAxV26O1FTt00NKfyk9YFVt41PO9WC6fUn8144LRdqbrEtGTe4W/hIbUNarD v9I2bSF/LX8OnGCibxSOxKwtCFpCMW84Mt4Bxa4yP8vcOOvTKhYehKoQkfEsaQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bMCd0581jzs0l; Tue, 17 Jun 2025 16:53:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 55HGrut7051781; Tue, 17 Jun 2025 16:53:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 55HGruXD051778; Tue, 17 Jun 2025 16:53:56 GMT (envelope-from git) Date: Tue, 17 Jun 2025 16:53:56 GMT Message-Id: <202506171653.55HGruXD051778@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: b59753f1d55d - main - tcp: provide a useful comment for struct tcpstat List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b59753f1d55da6c6d4b73252444212e6895ce913 Auto-Submitted: auto-generated The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=b59753f1d55da6c6d4b73252444212e6895ce913 commit b59753f1d55da6c6d4b73252444212e6895ce913 Author: Gleb Smirnoff AuthorDate: 2025-06-17 16:46:41 +0000 Commit: Gleb Smirnoff CommitDate: 2025-06-17 16:52:51 +0000 tcp: provide a useful comment for struct tcpstat --- sys/netinet/tcp_var.h | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/sys/netinet/tcp_var.h b/sys/netinet/tcp_var.h index d8822c40b17e..da4094b8ea4c 100644 --- a/sys/netinet/tcp_var.h +++ b/sys/netinet/tcp_var.h @@ -927,9 +927,12 @@ struct in_conninfo; + (tp)->t_rttvar) >> TCP_DELTA_SHIFT) /* - * TCP statistics. - * Many of these should be kept per connection, - * but that's inconvenient at the moment. + * Global (per-VNET) TCP statistics. The below structure represents what we + * export to the userland, but in the kernel we have an array of counter_u64_t + * with as many elements as there are members in the structure. The counters + * shall be increased by TCPSTAT_INC() or KMOD_TCPSTAT_INC(). Adding new a + * new counter also requires adding corresponding SDT probes into in_kdtrace.h + * and into in_kdtrace.c. */ struct tcpstat { uint64_t tcps_connattempt; /* connections initiated */