From owner-freebsd-ports@freebsd.org  Wed Aug  8 06:29:49 2018
Return-Path: <owner-freebsd-ports@freebsd.org>
Delivered-To: freebsd-ports@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2D8E21050541
 for <freebsd-ports@mailman.ysv.freebsd.org>;
 Wed,  8 Aug 2018 06:29:49 +0000 (UTC) (envelope-from yuri@rawbw.com)
Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org
 [IPv6:2001:1900:2254:206a::50:5])
 by mx1.freebsd.org (Postfix) with ESMTP id C535D71491
 for <freebsd-ports@freebsd.org>; Wed,  8 Aug 2018 06:29:48 +0000 (UTC)
 (envelope-from yuri@rawbw.com)
Received: by mailman.ysv.freebsd.org (Postfix)
 id 8A8541050540; Wed,  8 Aug 2018 06:29:48 +0000 (UTC)
Delivered-To: ports@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 79107105053F
 for <ports@mailman.ysv.freebsd.org>; Wed,  8 Aug 2018 06:29:48 +0000 (UTC)
 (envelope-from yuri@rawbw.com)
Received: from shell1.rawbw.com (shell1.rawbw.com [198.144.192.42])
 by mx1.freebsd.org (Postfix) with ESMTP id 0A11271490
 for <ports@freebsd.org>; Wed,  8 Aug 2018 06:29:47 +0000 (UTC)
 (envelope-from yuri@rawbw.com)
Received: from yv.noip.me (c-24-4-131-132.hsd1.ca.comcast.net [24.4.131.132])
 (authenticated bits=0)
 by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id w786Te2s008419
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO)
 for <ports@freebsd.org>; Tue, 7 Aug 2018 23:29:41 -0700 (PDT)
 (envelope-from yuri@rawbw.com)
X-Authentication-Warning: shell1.rawbw.com: Host
 c-24-4-131-132.hsd1.ca.comcast.net [24.4.131.132] claimed to be yv.noip.me
From: Yuri <yuri@rawbw.com>
Subject: Stage-qa doesn't complain about unstripped elfs in many cases
To: "ports@freebsd.org" <ports@freebsd.org>
Message-ID: <d39dba89-3d22-fbeb-3e40-5cdfe6c39310@rawbw.com>
Date: Tue, 7 Aug 2018 23:29:39 -0700
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Aug 2018 06:29:49 -0000

For example, on the misc/orange3 port:

 > $ make stage-qa
 > ====> Running Q/A tests (stage-qa)
 > [yuri@yv /usr/ports/misc/orange3]$ file 
./work-py36/stage/usr/local/lib/python3.6/site-packages/Orange/widgets/utils/_grid_density.so
 > 
./work-py36/stage/usr/local/lib/python3.6/site-packages/Orange/widgets/utils/_grid_density.so: 
ELF 64-bit LSB shared object, x86-64, version 1 (FreeBSD), dynamically 
linked, not stripped


This is because the stage-qa check only looks at .debug sections, and 
file(1) looks at more sections.

My proposed partial fix was rejected: 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230371 on the grounds 
that it goes against some other commit. So stage-qa doesn't check what 
it is supposed to check, and this is somehow ok.


Should this stage-qa check be changed to just run file(1) and check if 
the output contains "not stripped" in it? What would be the downside of 
this? I also don't understand what is the downside of the rejected patch 
in bug#230371 that expands the list of sections.


Yuri