Date: Wed, 10 Jun 2009 13:17:15 +0400 (MSD) From: Dmitry Morozovsky <marck@rinet.ru> To: Kip Macy <kmacy@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r193878 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <alpine.BSF.2.00.0906101315180.49870@woozle.rinet.ru> In-Reply-To: <200906100121.n5A1LWVO089719@svn.freebsd.org> References: <200906100121.n5A1LWVO089719@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 10 Jun 2009, Kip Macy wrote:
KM> + if ((((uint64_t)physmem * PAGESIZE) < (1ULL << 32)) &&
KM> + (zfs_prefetch_enable != 1) && (zfs_prefetch_disable != 1)) {
KM> + printf("ZFS NOTICE: system has less than 4GB and prefetch enable is not set"
KM> + "... disabling.\n");
KM> + zfs_prefetch_disable=1;
KM> + }
Also: this will disable prefetch on a system with exact 4G of memory *and*
some subsystem which allocates memory from system (e.g., integrated video)
Don't you think the threshold like 3G would be more appropriate?
--
Sincerely,
D.Marck [DM5020, MCK-RIPE, DM3-RIPN]
[ FreeBSD committer: marck@FreeBSD.org ]
------------------------------------------------------------------------
*** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru ***
------------------------------------------------------------------------
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.0906101315180.49870>