From owner-freebsd-current@FreeBSD.ORG  Fri Jan 28 19:11:36 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7C09716A4CE; Fri, 28 Jan 2005 19:11:36 +0000 (GMT)
Received: from mail2.dreamscape.com (mail2.dreamscape.com [206.64.128.18])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 086A943D1F; Fri, 28 Jan 2005 19:11:36 +0000 (GMT)
	(envelope-from krentel@dreamscape.com)
Received: from blue.mwk.domain (syr-mdm-06-216-171-177-210.dreamscape.com
	[216.171.177.210])j0SJBWlO022568;
	Fri, 28 Jan 2005 14:11:34 -0500 (EST)
Received: from blue.mwk.domain (localhost [127.0.0.1])
	by blue.mwk.domain (8.12.9p2/8.12.9) with ESMTP id j0SJETJH052081;
	Fri, 28 Jan 2005 14:14:30 -0500 (EST)
	(envelope-from krentel@blue.mwk.domain)
Message-Id: <200501281914.j0SJETJH052081@blue.mwk.domain>
To: "Poul-Henning Kamp" <phk@phk.freebsd.dk>,
	freebsd-current@freebsd.org
In-Reply-To: Your message of "Fri, 28 Jan 2005 13:59:15 +0100."
             <38517.1106917155@critter.freebsd.dk> 
Date: Fri, 28 Jan 2005 14:14:29 -0500
From: "Mark W. Krentel" <krentel@dreamscape.com>
X-Mailman-Approved-At: Sat, 29 Jan 2005 12:46:40 +0000
cc: Pawel Jakub Dawidek <pjd@freebsd.org>
Subject: Re: fstat triggered INVARIANTS panic in memrw() 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Jan 2005 19:11:36 -0000

>>>>> "PHK" == Poul-Henning Kamp <phk@phk.freebsd.dk> writes:

PHK> The only real problem here is that fstat(1) uses kvm in the first place.
PHK> The necessary information should be exported via sysctls.

PHK> No program used as part of regular system operation should use kvm.

Ok.  That still leaves btsockstat, netstat and trpt (and fstat) as
setgid kmem programs.  Are there plans to rewrite them?

Until then, I think it's not a bad idea to put a bandaid on fstat(1),
even if it's temporary.

Also, there's still the bug that kvm_read(3), and kmem(4) don't check
their arguments for values that lead to address wrap.

--Mark