From owner-freebsd-current@FreeBSD.ORG Thu Jun 26 11:53:02 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2970337B401; Thu, 26 Jun 2003 11:53:02 -0700 (PDT) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4E5EA43FE0; Thu, 26 Jun 2003 11:53:01 -0700 (PDT) (envelope-from imp@bsdimp.com) Received: from localhost (harmony.village.org [10.0.0.6]) by harmony.village.org (8.12.8/8.12.3) with ESMTP id h5QIqxE1065631; Thu, 26 Jun 2003 12:53:00 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Thu, 26 Jun 2003 12:52:55 -0600 (MDT) Message-Id: <20030626.125255.00013080.imp@bsdimp.com> To: wpaul@FreeBSD.ORG From: "M. Warner Losh" In-Reply-To: <20030626184848.46DB137B401@hub.freebsd.org> References: <20030626184848.46DB137B401@hub.freebsd.org> X-Mailer: Mew version 2.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: current@FreeBSD.ORG cc: sos@FreeBSD.ORG Subject: Re: Heads up: checking in change to ata-card.c X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jun 2003 18:53:02 -0000 Lose the attitude in the patch and email. otherwise it looks good. I'd rather that we had a table rather than doing the string coparison, but I can fix that after your commit. Warner