From owner-freebsd-current Mon Jan 6 17:30:03 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id RAA18928 for current-outgoing; Mon, 6 Jan 1997 17:30:03 -0800 (PST) Received: from phaeton.artisoft.com (phaeton.Artisoft.COM [198.17.250.211]) by freefall.freebsd.org (8.8.4/8.8.4) with SMTP id RAA18879; Mon, 6 Jan 1997 17:29:45 -0800 (PST) Received: (from terry@localhost) by phaeton.artisoft.com (8.6.11/8.6.9) id SAA13270; Mon, 6 Jan 1997 18:20:34 -0700 From: Terry Lambert Message-Id: <199701070120.SAA13270@phaeton.artisoft.com> Subject: Re: and MAKE_SET To: phk@freebsd.org Date: Mon, 6 Jan 1997 18:20:34 -0700 (MST) Cc: current@freebsd.org In-Reply-To: <12876.852124416@critter.dk.tfs.com> from "Poul-Henning Kamp" at Jan 1, 97 02:13:36 pm X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-current@freebsd.org X-Loop: FreeBSD.org Precedence: bulk > Isn't it wrong to have MAKE_SET() in ? What if you want > to use it from userland ? Yes, it should be in a sys include file #include'd by kernel.h One thing to think about is how GCC handles symbol aggregation like this on non-Intel platforms... it may need to be more abstract than it is if you want a general soloution which could find its way into a non-sys include file (and therefore find itself maintained by the GCC people instead of the FreeBSD people, among other benefits...). > Is the right solution to have a #ifdef KERNEL section of > or is it better to move MAKE_SET() and friends to another header, and > in such case, which ? lset.h? symset.h? linkset.h? Something that will (unfortunately) fit on on 8.3 DOS box... Terry Lambert terry@lambert.org --- Any opinions in this posting are my own and not those of my present or previous employers.