Date: Mon, 7 Sep 2015 21:01:16 -0600 From: Adam Weinberger <adamw@adamw.org> To: koobs@FreeBSD.org Cc: Alexey Dokuchaev <danfe@FreeBSD.org>, Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r396248 - head/games/scummvm Message-ID: <210C3ED0-81C7-4D4D-9876-FAD33413B06B@adamw.org> In-Reply-To: <55EE4208.3020405@FreeBSD.org> References: <201509070625.t876PBJV079503@repo.freebsd.org> <663DB8E120502884DE748209@atuin.in.mat.cc> <20150907070846.GA23292@FreeBSD.org> <55EE412F.4080802@FreeBSD.org> <55EE4208.3020405@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 7 Sep, 2015, at 20:03, Kubilay Kocak <koobs@FreeBSD.org> wrote: >=20 > On 8/09/2015 12:00 PM, Kubilay Kocak wrote: >> On 7/09/2015 5:08 PM, Alexey Dokuchaev wrote: >>> On Mon, Sep 07, 2015 at 08:46:51AM +0200, Mathieu Arnold wrote: >>>> +--On 7 septembre 2015 06:25:11 +0000 Alexey Dokuchaev = <danfe@FreeBSD.org> >>>> wrote: >>>> | New Revision: 396248 >>>> | URL: https://svnweb.freebsd.org/changeset/ports/396248 >>>> |=20 >>>> | Log: >>>> | - Ensure that build logs in bulk (package) mode are useful by = passing >>>> | the --enable-verbose-build argument to configure script >>>>=20 >>>> Why not always make the logs useful ? If I go and run make, I'll = have some >>>> output that's useless for me to debug, right ? >>>=20 >>> Typically yes, I agree; I also prefer to always have full logs. = However, >>> a lot of people prefer to see them when needed, not always; this = perception >>> could be popularized by Linux kernel build being quite by default, = OpeWRT, >>> etc. Our own Uses/cmake.mk defines CMAKE_VERBOSE for patch/package = builds >>> only. On the other hand, with pkg(8) and binary packages becoming = widely >>> adopted, perhaps we can assume that building from the ports is = expert mode >>> and thus --enable-verbose-build/CMAKE_VERBOSE=3Dyes/etc. should be = rightful >>> default. >>>=20 >>> I was trying to preserve existing defaults, yet not pessimize = cluster logs >>> usefullness. I think if we could have consensus among ports folks = that we >>> always prefer verbose logs, I'm all for removing the checks and just = always >>> pass it. In fact, this will make quite a few ports less cluttered. >>>=20 >>> ./danfe >>>=20 >>=20 >> That (preserving/respecting current defaults) is the right thing to = do. >>=20 >> I advocate verbose by default across the board in the ports I = maintain >> already. Our defaults should be conducive to debug-ability, = particularly >> for the case of users providing feedback for maintainers. >>=20 >> How about we exp-run for GNU_CONFIGURE=3Dyes ports: >>=20 >> CONFIGURE_ARGS+=3D --disable-silent-rules >> MAKE_ENV+=3D V=3D1 (maybe even MAKE_ARGS) >>=20 >> OR: >>=20 >> Templates/config.site =3D enable_silent_rules=3Dno, and >> MAKE_ENV+=3D V=3D1 (maybe even MAKE_ARGS) >>=20 >> AND maybe even: >>=20 >> Quoting from: >> = https://www.gnu.org/software/automake/manual/html_node/Automake-Silent-Rul= es.html >>=20 >> "Still, notwithstanding the rationales above, a developer who really >> wants to make silent rules enabled by default in his own package can = do >> so by calling AM_SILENT_RULES([yes]) in configure.ac. " >>=20 >> Could we also REINPLACE_CMD that? >>=20 >> Quoting relevant snippets from above link: >>=20 >> Passing --enable-silent-rules to configure will cause build rules to = be >> less verbose; the option --disable-silent-rules will cause normal >> verbose output." >>=20 >> At make run time, the default chosen at configure time may be >> overridden: make V=3D1 will produce verbose output, make V=3D0 less = verbose >> output. >>=20 >> Also, in projects using libtool, the use of silent rules can >> automatically enable the libtool=E2=80=99s --silent option >>=20 >=20 > There's also no reason we couldn't wrap what we do in a user > option/knob, so that builds could be made verbose/silent in particular > cases, or at the users command. Very much +1'd here. Putting PORTS_VERBOSE_BUILD=3Dyes into = /etc/make.conf makes it real easy for people to enable it if they want. = Or the opposite if we want it defaulting to on. It also becomes something that poudriere can set intelligently. bulk = would likely want it defaulting to quiet (normal) mode, and testport = would likely want it defaulting to verbose mode. I just don't think that "this would be helpful to me" should have to = equal "therefore everybody is going to want this change." # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?210C3ED0-81C7-4D4D-9876-FAD33413B06B>