From owner-svn-src-head@FreeBSD.ORG  Wed Dec 21 20:49:40 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8EA48106564A;
	Wed, 21 Dec 2011 20:49:40 +0000 (UTC)
	(envelope-from lists@eitanadler.com)
Received: from mail-lpp01m010-f54.google.com (mail-lpp01m010-f54.google.com
	[209.85.215.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 6A9948FC12;
	Wed, 21 Dec 2011 20:49:38 +0000 (UTC)
Received: by lahl5 with SMTP id l5so4401672lah.13
	for <multiple recipients>; Wed, 21 Dec 2011 12:49:38 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=eitanadler.com; s=0xdeadbeef;
	h=mime-version:sender:in-reply-to:references:from:date
	:x-google-sender-auth:message-id:subject:to:cc:content-type
	:content-transfer-encoding;
	bh=b1bIYzqgzDSCvdpWl7VA3CSLn4g9IXkUBeallX7bYTo=;
	b=KKV/bla3QzzY+X44stYag8kuXbUibKQk57U5EtaYr142ncBEV/TzMpGTPgWcy0FBoG
	4v0YOydQkPQioTcYwV6ZA8BGFPXyUNuWDX/tRqDGaOAyDtTU8rODH7hKyRX4PqpI4I2R
	/sNQfJ7yNP02I8bDfcbLC9qPIDwyRzT8R1OLw=
Received: by 10.152.128.196 with SMTP id nq4mr7416830lab.35.1324500578115;
	Wed, 21 Dec 2011 12:49:38 -0800 (PST)
MIME-Version: 1.0
Sender: lists@eitanadler.com
Received: by 10.152.129.8 with HTTP; Wed, 21 Dec 2011 12:49:07 -0800 (PST)
In-Reply-To: <4EF244CA.8040108@FreeBSD.org>
References: <201112212027.pBLKRfPK084637@svn.freebsd.org>
	<4EF243F2.7030000@FreeBSD.org>
	<CAF6rxgku88PABx9J8UxfLkKm+Y-3b6+DB+X6cjUce-LfX7VESg@mail.gmail.com>
	<4EF244CA.8040108@FreeBSD.org>
From: Eitan Adler <eadler@freebsd.org>
Date: Wed, 21 Dec 2011 15:49:07 -0500
X-Google-Sender-Auth: Lc27vM2fo8r1xv8YXVYywQLXR-A
Message-ID: <CAF6rxgkBWXgJ0HKXB=WMUDC09S9u3m_9fnkNkM6O1GNGR7Yhuw@mail.gmail.com>
To: Doug Barton <dougb@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r228790 - in head/usr.sbin: fwcontrol newsyslog
	ypserv
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Dec 2011 20:49:40 -0000

On Wed, Dec 21, 2011 at 3:42 PM, Doug Barton <dougb@freebsd.org> wrote:
> On 12/21/2011 12:40 PM, Eitan Adler wrote:
>> On Wed, Dec 21, 2011 at 3:39 PM, Doug Barton <dougb@freebsd.org> wrote:
>>> A better way to write this commit log would be, "Remove null pointer
>>> checks that are extraneous because ..." =C2=A02/3 why, 1/3 what.
>>
>> Noted.
>
> Thanks. However, I was perhaps too subtle in asking you to actually
> explain why they were not needed. =C2=A0:)

- free never requires a null check
- zwork is dereferenced in the line before the null check


--=20
Eitan Adler
Ports committer
X11, Bugbusting teams