From nobody Sat Jan 18 18:05:26 2025 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Yb4Jk4CTjz5kgMR for ; Sat, 18 Jan 2025 18:05:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Yb4Jk3TYhz3x5t for ; Sat, 18 Jan 2025 18:05:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737223526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bL3AasekrD5CySkSWcBJ18BI+pW9MTaxIHI6RSkPXSM=; b=ovsB+ndqY9sjrV+VRu6i4CinUHAdHHIcNUjjGEDXJ1wtuTdarhd6L964XvAY4si30Zx1wc JhrsV5mPSMSAR93bDRTc2sF1ZHzcrjgXH5ZTYUSZIyKSVMrk9Pq6j0sIGoO05V5ItEPSIX zQRhD/JjUJqPQI/44Bei14NVpnAS1j8m+inak3KSq0dL0rqPuMaDr4dNiSxtbRLY25EC+r zH+YWmbW9hpC5uzboGr4MczdVTNJDrZJLt/Yyq3ZStvGO8XYnQSbCuYrr7Bs8Thz//6039 gQvjyYhdGfI7DPl8wnh21Iibm7WWF4VMbWpzMOauax871frKOCLBVUXntmL2tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737223526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bL3AasekrD5CySkSWcBJ18BI+pW9MTaxIHI6RSkPXSM=; b=eaNf+6yLnKTI/uhFAB5M5kJ30DFb0d77I2WXaqj6RS3W4TsD0Jk18MYsdU0ZQwbmKW4Rdm b+ClhQ1W0QkLSQ7MPhqXgTSfPGDUdVTKFG6RgqwAdFkxjul0bu19R/JRtC00jMmSXlpt4Q XXCTZT5qkBvoceo3g0FmmX8HI5LidPaXm8gkHQBZ9mRizydcG4/WlhAGuUMU7d4yjtYWbW 7pVDA4HUXDoODNop5zNSxAQ6aGUBPohjWbXWCiBTgpDakVffowe98G+TZMPHgBrvLiTVKs 3rM4B2huj3GTdvgYnH2TWWrz+RL3odLYC7YJSxES88RuwC73QO0Vjm8qjUt7Fw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737223526; a=rsa-sha256; cv=none; b=KBbG0Ap1voBXBrISjfCwVw0u+S3KFFqKdQ/36zcGMWTWfElITurNrAvxM6FXr2RbHGe6Jo ADmXWJeZJTVwpWED8+tY0ONQ0z0tnraNV8FYtXEr/Nudc/9fuG1rvnA0SGrBvuks+67SFd m7/ol5UgsWPkeVslS9rbeU2liiA8DB01/ihjYfXu29Z8FGb/ZuRSDT0lJYQY9Rd3Z4bQE4 Q9mWaGPWcQ3huwsSE8/Kshu/QdeS6fe9CRdWqSpU7qkDAM4taxJaNuJQxrNHkzyvRTUyIA LG5oZryd3TwPsC8AqG498qr77XTF41qstoDCSnFEeDF4KgzRYL5PXdGV/a9XAw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Yb4Jk2KnjzkC for ; Sat, 18 Jan 2025 18:05:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 50II5QOe097867 for ; Sat, 18 Jan 2025 18:05:26 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 50II5Q14097866 for bugs@FreeBSD.org; Sat, 18 Jan 2025 18:05:26 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 284140] ifconfig carp : unicast switch back to multicast when not specifying peer Date: Sat, 18 Jan 2025 18:05:26 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 14.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: johan@nosd.in X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D284140 Bug ID: 284140 Summary: ifconfig carp : unicast switch back to multicast when not specifying peer Product: Base System Version: 14.2-RELEASE Hardware: amd64 OS: Any Status: New Severity: Affects Many People Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: johan@nosd.in Using carp in unicast, changing any other attribute than "peer" switch back= to unicast : root@testvip1:~ # ifconfig epair0b epair0b: flags=3D1008943 metric 0 mtu 9000 options=3D8 ether 2c:44:fd:19:94:db hwaddr 02:03:7f:1f:e6:0b inet 192.168.1.83 netmask 0xffffff00 broadcast 192.168.1.255 inet 192.168.1.85 netmask 0xffffff00 broadcast 192.168.1.255 vhid 99 groups: epair carp: BACKUP vhid 99 advbase 1 advskew 150 peer 192.168.1.84 peer6 ff02::12 media: Ethernet 10Gbase-T (10Gbase-T ) status: active nd6 options=3D29 root@testvip1:~ # ifconfig epair0b vhid 99 advskew 50 root@testvip1:~ # ifconfig epair0b epair0b: flags=3D1008943 metric 0 mtu 9000 options=3D8 ether 2c:44:fd:19:94:db hwaddr 02:03:7f:1f:e6:0b inet 192.168.1.83 netmask 0xffffff00 broadcast 192.168.1.255 inet 192.168.1.85 netmask 0xffffff00 broadcast 192.168.1.255 vhid 99 groups: epair carp: MASTER vhid 99 advbase 1 advskew 50 peer 224.0.0.18 peer6 ff02::12 media: Ethernet 10Gbase-T (10Gbase-T ) status: active nd6 options=3D29 This is caused by multicast set as default in carp_ctor in sbin/ifconfig/carp.c, so when setcarp_callback run it sets carpr.carpr_addr back to 224.0.0.18. On my setup, commenting default values works like assumed, and first initialization also correctly set peer to 224.0.0.18 if not specified by ifconfig. Maybe these default values could be removed ? iff --git a/sbin/ifconfig/carp.c b/sbin/ifconfig/carp.c index dd09838b5d8b..ef24b0899fe7 100644 --- a/sbin/ifconfig/carp.c +++ b/sbin/ifconfig/carp.c @@ -246,10 +264,6 @@ static struct afswtch af_carp =3D { static __constructor void carp_ctor(void) { - /* Default to multicast. */ - setcarp_mcast(NULL, NULL, 0); - setcarp_mcast6(NULL, NULL, 0); - for (size_t i =3D 0; i < nitems(carp_cmds); i++) cmd_register(&carp_cmds[i]); af_register(&af_carp); --=20 You are receiving this mail because: You are the assignee for the bug.=