From owner-svn-src-all@freebsd.org Tue Aug 27 09:56:40 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 91FE6D188C; Tue, 27 Aug 2019 09:56:40 +0000 (UTC) (envelope-from melounmichal@gmail.com) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46HkmR4Yqhz3BtS; Tue, 27 Aug 2019 09:56:39 +0000 (UTC) (envelope-from melounmichal@gmail.com) Received: by mail-wm1-x341.google.com with SMTP id i63so2324700wmg.4; Tue, 27 Aug 2019 02:56:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:reply-to:subject:to:cc:references:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=WK0lKMqesdW4pxEf2rIAmFAaCc0uJnbzqMsYYTMVE6o=; b=B523OmJL/V+dhMxSN0xAGJEJKYk6jAEu1bsnQWXbNgb+hFbAm9jrd5Q6jg7d3uVU9O e0Fm2cPEMVbSKqG6LIR9J6Qb7SzOvWc1myuhShSQpLKwqEBw5n6LAIV34nPaIembV4Tg NfebPoMvX5ahC+0soOdao4N34LRsV4IhDWok6xOX24YllrlkGjsROGs/l1Wev/J5ZMB4 osTuc19luKnFbuSMfpPFDvLOcGzC/5aV5ncEj43y/GAM+B658OQ28YvvINHqORc1ivQT qYQTXwfhj0qZ6FnatV9FEhAK/jxlk5zAApwLGQrln5w+9WH0318LRP9XLw/MnIE4nUqf 3G8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:reply-to:subject:to:cc:references :openpgp:autocrypt:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=WK0lKMqesdW4pxEf2rIAmFAaCc0uJnbzqMsYYTMVE6o=; b=Q9HQTdfAQIVrSHENUlSG0MPJdrcwbnlUfh96FLWl2LKKHhlN9PSEq9Nr+BCPTsi/HG cX+RdebNQSFuFxSZww2h/RiKC0qgDQYzw1LjqIUrD683lf9KLK1Lk9wvGtmupeJOMgto nqhNBeMq95/EN2tqVElTS9qj2oodvO5oNfoSTqhZzMm87iiZXWiw5grPebaEgB7kNqB9 1NqRIv2+I1c5f+BDAm1ksoMDGQJ7gFoh870+d1edpHabZ1Vk7FCfzrkxFrZp+ZUfpsw2 sehCrfN5TISaP9HW62jDBWbMid6brelWeZgKiU3s4HBHprT0QRuXutaKVb54x2cjeQCG G8UA== X-Gm-Message-State: APjAAAUu/Jc2Rp4cDEWexe20EoaUmDYI3McVZFdd/zd1DxExJZBqbDFx sWHaOzmSEdJg08ledniMnrxZp4/G X-Google-Smtp-Source: APXvYqxhuEbb5cPU+3GaWQNOx7jsFi+MMX9KLsTT7iEQZHSUipT64MywEnpRMEbFXHnAGyWEW5EOZQ== X-Received: by 2002:a1c:4383:: with SMTP id q125mr9190881wma.16.1566899796803; Tue, 27 Aug 2019 02:56:36 -0700 (PDT) Received: from [88.208.79.100] (halouny.humusoft.cz. [88.208.79.100]) by smtp.gmail.com with ESMTPSA id 91sm48168093wrp.3.2019.08.27.02.56.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Aug 2019 02:56:36 -0700 (PDT) Sender: Michal Meloun From: Michal Meloun X-Google-Original-From: Michal Meloun Reply-To: mmel@freebsd.org Subject: Re: svn commit: r351187 - head/sys/arm64/rockchip To: Peter Jeremy Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201908180919.x7I9JXGj021325@repo.freebsd.org> <20190825072844.GA4799@server.rulingia.com> Openpgp: preference=signencrypt Autocrypt: addr=mmel@freebsd.org; prefer-encrypt=mutual; keydata= mQENBFYuVRkBCADZiwLCCne3wG9b9k+R2Neo5zVo2bLaZRfNNY/v9kg283i0sb1Da4EdEiNT 15El5UyozhphUIbIR/zrVpxF1TvvFdoCyzx6a68bNY2d9dBrDcNDZC+XnyDdHQoobN87DWT1 mRVkmbg9LHZ/SVUOkGYuWyE+8UYeDAcUizuXwSK5zFWmeTyIoWNa68ifrWLfQe0p4x5jC/AI VURCi17p360vU4fhgwoMvEEhrRBWCr4DYHToFjIt2WdBy3GR1qoO0+Xkd6G+OoBULo+XDfgu L2WdPvh0K69F9/LgHkMmG5Il7SCe62QGpG2vaCgRV7BQhLX+kxlvM+WrdRatWRml4Y/3ABEB AAG0IE1pY2hhbCBNZWxvdW4gPG1tZWxAZnJlZWJzZC5vcmc+iQFXBBMBCgBBAhsDBQsJCAcD BRUKCQgLBRYDAgEAAh4BAheAAhkBFiEEAN1KEEuAn+Apg413aR6ya17FqqoFAlw3aO8FCQ9v FVYACgkQaR6ya17FqqrIFwf/V/NRuAutw1cZ/HRCwfp00KY+8g730KwOaAMhPYvq8tqf8krD whFRWt9s4DSVTVJUC2dRZa5g1MS77iQL/WWzBUhJj7rW4uMpcKpi7UXi060sKrnE+1ZBvanG 8YCMTHKxQgQDD0cBqsyOAfrSA+Pyya3/HyAh1vvjQZfu5vWxA1X5NX5l5KtonprJ+ybVacwO W34yfWSX+ncx089JpUknenGdI+gVoKfa6uh/8YiCZTI5poxBttrOB8NGfylTsTTTbw2pkire Vkc87qq++I9bBNtTqWOZjB/3KBUd4q1veEUa4MS63TWtAvcEcsxHiBv4AH6npPO/iPycuGGh qldT1LkBDQRWLlUZAQgAuqBGR9LbUP86pYT2Zd+HZsiOun24LxPQwK6KZuysB0so02isa7ac T6t5uBfyfmdgzfvsc6dqU8bI65e8JtDwwVVF1Y4fF6cmNcmJqU10Gw5/bAu9re9JJWx2g/OJ tYMhwmqEE5DcS6GwgvJZI+9hgoSLL3mZ+GsO25NM4BhVH1o1AE4Q3O0HZMMnIzH+pma0augZ Xc3Qep17/Occ+1A7xEbn8VAYx8cwjkYUy7JyvVx4ecuj+i+uoCXhNhX5QdIcn4UMT1233Bcd yVZtZsLTI26ByFmrquGjkmN+/hra/s+nKfcegOKeHWVY/uFgDRk0TEYd6QuddZWo7+XMZLps wQARAQABiQElBBgBCgAPAhsMBQJZjBHDBQkHICOqAAoJEGkesmtexaqquysH/iDgRIrlMvFT GLyktZws/K/C03gWZ/tWwJV5+SFqRoasM+Z+9+cb44XA3rReqieLsYF5qSXTXHBPhEg1+9V9 KEPLpwektLtAv8zynN+6VVffwyRWQ4PIZmHCMT6PJP+Rk0DU6VrDc3ch58erduuyRDsbh32g 96nYMNvDsLhDvq44GPHLfglUHRY6wHo3IxAH2HosaWNC10R13JSrCdFnPMeIa+nSE+11hAdB mWpuPgVX2VNErtrwSBr7LsyCZ4yLO0bN5fKM0/Tavc9EcI9qDBrnts/EfZoCHhDtTMEFnQZM ybsMso20I/nxYPFuWuuFn7uQeoYrwWxt15SkN0RgtV2JATwEGAEKACYCGwwWIQQA3UoQS4Cf 4CmDjXdpHrJrXsWqqgUCXDdpmwUJD28WAgAKCRBpHrJrXsWqqtOrB/9Okk/dm2/mAs3tbA6l lKOZAwfUwBonwG7YhK9dOb5No/bJoY8G9s2IVXqwWKqCDv1qKC4M8pMXPD9fVsfNPG8GA1GZ rpZoZxHFteXZHoE1grpWypE0T3hp1W0hQNWXKv0MSuEMRVKU1m/iyLa10X7q8BaKtEDs35Xf DCh7eVg1vqiKtWyFn1u+y9Gy1Ztc/SKTs8mQvMYNUdBZuV6vN0VSz3I6wD9HVfo6Eo3M7cVp qqQ+KhrrGiCCYQPfZwpFAJSSgV3bR5O0BlNaGKJOoVTV1yexRbVEStswiFP8JFQp6U+S3nqE FFob7daQBLxi80oUVRn6eEdzR8tBhIy7sbeD Message-ID: <6da78585-2bc7-0228-e443-799643d08783@freebsd.org> Date: Tue, 27 Aug 2019 11:56:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190825072844.GA4799@server.rulingia.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46HkmR4Yqhz3BtS X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=B523OmJL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of melounmichal@gmail.com designates 2a00:1450:4864:20::341 as permitted sender) smtp.mailfrom=melounmichal@gmail.com X-Spamd-Result: default: False [-3.95 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[mmel@freebsd.org]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.95)[-0.948,0]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (3.09), ipnet: 2a00:1450::/32(-3.00), asn: 15169(-2.33), country: US(-0.05)]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[1.4.3.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Aug 2019 09:56:40 -0000 On 25.08.2019 9:28, Peter Jeremy wrote: > On 2019-Aug-18 09:19:33 +0000, Michal Meloun > wrote: >> Improve rk_pinctrl driver: > > Sorry for the late notice but this breaks my Rock64 (RK3328). > Sorry for late response. Seems like this is caused by unnoticed dependency between patches in my worktree, sorry for this. I hope that r351543 solves it. Can you, please, try r351543 on Rock64 because I haven't any rk3328 based board for real test? Thanks Michal > I'm using: U-Boot 2017.09-rockchip-ayufan-1035-gd646df03ac (Oct 26 > 2018 - 08:36:01 +0000) > > At r351452, the kernel boot looks like: ... gic0: Interrupt Controller> mem > 0xff811000-0xff811fff,0xff812000-0xff813fff,0xff814000-0xff815fff,0xff816000-0xff817fff > irq 48 on ofwbus0 gic0: pn 0x2, arch 0x2, rev 0x1, implementer > 0x43b irqs 160 rk_pinctrl0: on > ofwbus0 rk_pinctrl0: Cannot attach GPIO subdevice: gpio0@ff210000 > rk_pinctrl0: Cannot attach GPIO subdevice: gpio1@ff220000 > rk_pinctrl0: Cannot attach GPIO subdevice: gpio2@ff230000 > rk_pinctrl0: Cannot attach GPIO subdevice: gpio3@ff240000 panic: > acquiring blockable sleep lock with spinlock or critical section > held (sleep mutex) pmap @ /usr/src/sys/arm64/arm64/pmap.c:5819 > cpuid = 0 time = 1 KDB: stack backtrace: db_trace_self() at > db_trace_self_wrapper+0x28 pc = 0xffff00000054c9ac lr = > 0xffff0000000e2908 sp = 0xffff000000010100 fp = > 0xffff000000010310 > > db_trace_self_wrapper() at vpanic+0x18c pc = 0xffff0000000e2908 lr > = 0xffff00000027e848 sp = 0xffff000000010320 fp = > 0xffff0000000103c0 > > vpanic() at panic+0x44 pc = 0xffff00000027e848 lr = > 0xffff00000027e5f8 sp = 0xffff0000000103d0 fp = > 0xffff000000010450 > > panic() at witness_checkorder+0xa80 pc = 0xffff00000027e5f8 lr = > 0xffff0000002e5348 sp = 0xffff000000010460 fp = > 0xffff0000000104d0 > > witness_checkorder() at __mtx_lock_flags+0xb0 pc = > 0xffff0000002e5348 lr = 0xffff00000025e574 sp = 0xffff0000000104e0 > fp = 0xffff000000010520 > > __mtx_lock_flags() at pmap_fault+0x1bc pc = 0xffff00000025e574 lr > = 0xffff000000566c00 sp = 0xffff000000010530 fp = > 0xffff000000010550 > > pmap_fault() at data_abort+0xc0 pc = 0xffff000000566c00 lr = > 0xffff000000568a68 sp = 0xffff000000010560 fp = > 0xffff000000010610 > > data_abort() at do_el1h_sync+0x128 pc = 0xffff000000568a68 lr = > 0xffff0000005688a4 sp = 0xffff000000010620 fp = > 0xffff000000010650 > > do_el1h_sync() at handle_el1h_sync+0x74 pc = 0xffff0000005688a4 lr > = 0xffff00000054f074 sp = 0xffff000000010660 fp = > 0xffff000000010770 > > handle_el1h_sync() at simple_mfd_syscon_modify_4+0x60 pc = > 0xffff00000054f074 lr = 0xffff0000000fd334 sp = 0xffff000000010780 > fp = 0xffff000000010830 > > simple_mfd_syscon_modify_4() at rk_pinctrl_configure_pins+0x1b4 pc > = 0xffff0000000fd334 lr = 0xffff0000005795fc sp = > 0xffff000000010840 fp = 0xffff0000000108c0 > > rk_pinctrl_configure_pins() at pinctrl_configure_children+0x120 pc > = 0xffff0000005795fc lr = 0xffff0000000fc4dc sp = > 0xffff0000000108d0 fp = 0xffff000000010950 > > pinctrl_configure_children() at fdt_pinctrl_configure_tree+0x20 pc > = 0xffff0000000fc4dc lr = 0xffff0000000fc3a8 sp = > 0xffff000000010960 fp = 0xffff000000010970 > > fdt_pinctrl_configure_tree() at rk_pinctrl_attach+0x310 pc = > 0xffff0000000fc3a8 lr = 0xffff000000579414 sp = 0xffff000000010980 > fp = 0xffff0000000109e0 > > rk_pinctrl_attach() at device_attach+0x3f4 pc = 0xffff000000579414 > lr = 0xffff0000002b3f18 sp = 0xffff0000000109f0 fp = > 0xffff000000010a40 > > device_attach() at bus_generic_new_pass+0x12c pc = > 0xffff0000002b3f18 lr = 0xffff0000002b5ccc sp = 0xffff000000010a50 > fp = 0xffff000000010a80 > > bus_generic_new_pass() at bus_generic_new_pass+0xe4 pc = > 0xffff0000002b5ccc lr = 0xffff0000002b5c84 sp = 0xffff000000010a90 > fp = 0xffff000000010ac0 > > bus_generic_new_pass() at bus_generic_new_pass+0xe4 pc = > 0xffff0000002b5c84 lr = 0xffff0000002b5c84 sp = 0xffff000000010ad0 > fp = 0xffff000000010b00 > > bus_generic_new_pass() at bus_set_pass+0x8c pc = 0xffff0000002b5c84 > lr = 0xffff0000002b1674 sp = 0xffff000000010b10 fp = > 0xffff000000010b40 > > bus_set_pass() at mi_startup+0x238 pc = 0xffff0000002b1674 lr = > 0xffff000000217b50 sp = 0xffff000000010b50 fp = > 0xffff000000010bb0 > > mi_startup() at virtdone+0x54 pc = 0xffff000000217b50 lr = > 0xffff000000001084 sp = 0xffff000000010bc0 fp = > 0x0000000000000000 ---- > > When I revert r351187, I get: ... gic0: Controller> mem > 0xff811000-0xff811fff,0xff812000-0xff813fff,0xff814000-0xff815fff,0xff816000-0xff817fff > irq 48 on ofwbus0 gic0: pn 0x2, arch 0x2, rev 0x1, implementer > 0x43b irqs 160 rk_pinctrl0: on > ofwbus0 rk_i2c0: mem 0xff160000-0xff160fff irq 16 on > ofwbus0 iicbus0: on rk_i2c0 gpio0: Bank controller> mem 0xff210000-0xff2100ff irq 51 on rk_pinctrl0 > gpiobus0: on gpio0 gpio1: controller> mem 0xff220000-0xff2200ff irq 52 on rk_pinctrl0 > gpiobus1: on gpio1 gpio2: controller> mem 0xff230000-0xff2300ff irq 53 on rk_pinctrl0 > gpiobus2: on gpio2 gpio3: controller> mem 0xff240000-0xff2400ff irq 54 on rk_pinctrl0 > gpiobus3: on gpio3 rk805_pmu0: at > addr 0x30 irq 55 on iicbus0 ... > > I haven't dug into this further yet. >