From owner-freebsd-emulation@FreeBSD.ORG  Sat Sep 27 15:28:46 2008
Return-Path: <owner-freebsd-emulation@FreeBSD.ORG>
Delivered-To: freebsd-emulation@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 53CFF10656F3
	for <freebsd-emulation@freebsd.org>;
	Sat, 27 Sep 2008 15:28:46 +0000 (UTC)
	(envelope-from anthony@codemonkey.ws)
Received: from rn-out-0910.google.com (rn-out-0910.google.com [64.233.170.186])
	by mx1.freebsd.org (Postfix) with ESMTP id 472318FC19
	for <freebsd-emulation@freebsd.org>;
	Sat, 27 Sep 2008 15:28:42 +0000 (UTC)
	(envelope-from anthony@codemonkey.ws)
Received: by rn-out-0910.google.com with SMTP id j71so438117rne.12
	for <freebsd-emulation@freebsd.org>;
	Sat, 27 Sep 2008 08:28:41 -0700 (PDT)
Received: by 10.100.8.4 with SMTP id 4mr2455371anh.137.1222529321773;
	Sat, 27 Sep 2008 08:28:41 -0700 (PDT)
Received: from squirrel.codemonkey.ws (cpe-24-28-0-183.austin.res.rr.com
	[24.28.0.183])
	by mx.google.com with ESMTPS id c28sm88785anc.16.2008.09.27.08.28.40
	(version=TLSv1/SSLv3 cipher=RC4-MD5);
	Sat, 27 Sep 2008 08:28:41 -0700 (PDT)
Message-ID: <48DE50EC.4090003@codemonkey.ws>
Date: Sat, 27 Sep 2008 10:27:40 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
User-Agent: Thunderbird 2.0.0.16 (X11/20080723)
MIME-Version: 1.0
To: qemu-devel@nongnu.org, freebsd-emulation@freebsd.org
References: <20080921204025.GA81055@saturn.kn-bremen.de>
	<200809242210.m8OMAcSZ021572@saturn.kn-bremen.de>
	<20080925201703.GA12142@saturn.kn-bremen.de>
	<48DBF71E.1000405@codemonkey.ws>
	<20080926212925.GA10666@saturn.kn-bremen.de>
In-Reply-To: <20080926212925.GA10666@saturn.kn-bremen.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: 
Subject: Re: [Qemu-devel] [PATCH] preprocessor issue in
	qemu/patch-block-raw-posix.c
X-BeenThere: freebsd-emulation@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Development of Emulators of other operating systems
	<freebsd-emulation.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-emulation>
List-Post: <mailto:freebsd-emulation@freebsd.org>
List-Help: <mailto:freebsd-emulation-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Sep 2008 15:28:46 -0000

Juergen Lock wrote:
> On Thu, Sep 25, 2008 at 03:39:58PM -0500, Anthony Liguori wrote:
>   
>> Juergen Lock wrote:
>>     
>>> I forgot to note that this also needed the following patch:
>>>   
>>>       
>> Why?  This #ifdef is working around a very specific bug.
>>
>>     
> Well, looks like the preprocessor tries to parse the entire expression
> including the undefined `!__GLIBC_PREREQ(2, 4)' before evaluating it:
>
> block-raw-posix.c:548:69: missing binary operator before token "("
>
> so I just put it on an extra line.
>   

It's fixed in SVN now.

Regards,

Anthony Liguori