From owner-freebsd-net@freebsd.org Tue Oct 20 20:58:46 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 844F643AABB for ; Tue, 20 Oct 2020 20:58:46 +0000 (UTC) (envelope-from milosz.kaniewski@gmail.com) Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CG5ZY4sjzz4ktB for ; Tue, 20 Oct 2020 20:58:45 +0000 (UTC) (envelope-from milosz.kaniewski@gmail.com) Received: by mail-ed1-x530.google.com with SMTP id cq12so189094edb.2 for ; Tue, 20 Oct 2020 13:58:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=4KEZIO43/tp7MrlknX+ljJEBNQRMogcvgpfx/YJWOGA=; b=Sn3UnxJ9CW1iXRIIA8SzsNso/zINiyjCXDR5tDnDceWxdhXxwUTq1BjEpFOIJ4HUNm d7Y3WOhimlE7Zvgj4j3qkWaBMtc/H+CLj3MYXEVHnwgOBIJShnMIw9A27ROEhpNmisqn JokVdkJwaE8FpWnhGHu85k83aF+5Pc6WO3mJFNDI/+ZRi+tNqE+pvMtoynlcK+Us1XHE 8qxxhrv58haTGbjED71AUUhie4FZl37jgFb+HmvvcT9dUoAU9tD8w9qjUkKubQ1HtbW2 t4vrNIDgGp00I+Qu7A8tSIa14TuNtGILq5Zd4orbF9L1nV47+GmDJbTu/WHXRVwdnlxD Z+6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=4KEZIO43/tp7MrlknX+ljJEBNQRMogcvgpfx/YJWOGA=; b=caEfHENLr2uaINaN63I3LTKkJ3XljmK5K7iZ9JjUylOUEq3Fdm063NInUFDLCTJ/tu EUp9Iz9Ou2D+hVBcPfoOJP3ymMVwZqosEK3W1xTp1J3jtRR9LI7B/uji+FfdrGAq9Wnp lG5Z4W1JAsg9Ro91zjnWiXRh/707GLbQrhiAfrvuU9TTqVCCq3cmqLTr+vRCb2VN+5oK B0VbpkxFP6Z75rkwVspARt76BpDQqhM0M7af8Vz6S5mYjZSXBzOEd22g+75j4ZGyf0i1 kWvRJULOUvwbZOu1bIYDy13edc1rd89Rkj7FOsl7QfeFAQOcGCg5ARkU+1BH0fRkvjPb W8Mw== X-Gm-Message-State: AOAM5305m42SF7J3QIw/Lokoxyu1xLXydtdGqxelSvO6gfq12Tsn/xTS nKIOy3tra3p3CIy8i2h/JJmzMPjFV48sWWXG+PzVXfedPXRHQw== X-Google-Smtp-Source: ABdhPJxSy+JPWTDtbH7tSTp9WzW04ceeXSiiY2V+zsPFsyHsQN7oIEcyn9ih9aRLhfnEiBVOrYpMQCpStGmJrGSJGJM= X-Received: by 2002:aa7:dada:: with SMTP id x26mr4773862eds.167.1603227523758; Tue, 20 Oct 2020 13:58:43 -0700 (PDT) MIME-Version: 1.0 From: =?UTF-8?Q?Mi=C5=82osz_Kaniewski?= Date: Tue, 20 Oct 2020 22:58:25 +0200 Message-ID: Subject: safe_pause_us() is always at least 1 millisecond long To: freebsd-net@freebsd.org X-Rspamd-Queue-Id: 4CG5ZY4sjzz4ktB X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Sn3UnxJ9; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of miloszkaniewski@gmail.com designates 2a00:1450:4864:20::530 as permitted sender) smtp.mailfrom=miloszkaniewski@gmail.com X-Spamd-Result: default: False [-3.29 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.02)[-1.016]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.03)[-1.029]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::530:from]; NEURAL_HAM_SHORT(-0.25)[-0.247]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; TAGGED_FROM(0.00)[]; MAILMAN_DEST(0.00)[freebsd-net]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Oct 2020 20:58:46 -0000 Hi, I was recently doing some tests and found out that on the iflib e1000 driver I can do much less media status checks per second compared to the non-iflib driver. I found out that this is caused by the definition of safe_pause_us() which calls: pause("e1000_delay", max(1, x/(1000000/hz))); If I understand everything correctly then it means that safe_pase_us() is always at least 1 millisecond long (if a clock is 1000 Hz). Shouldn't it use min() instead? Thanks, Milosz