From owner-freebsd-stable Thu Jun 20 17: 0:41 2002 Delivered-To: freebsd-stable@freebsd.org Received: from mail.dt.e-technik.uni-dortmund.de (krusty.dt.E-Technik.Uni-Dortmund.DE [129.217.163.1]) by hub.freebsd.org (Postfix) with ESMTP id 1D31E37B40F for ; Thu, 20 Jun 2002 17:00:27 -0700 (PDT) Received: from merlin.emma.line.org (localhost [127.0.0.1]) by mail.dt.e-technik.uni-dortmund.de (Postfix) with ESMTP id EC28CA3831 for ; Fri, 21 Jun 2002 02:00:25 +0200 (CEST) Received: by merlin.emma.line.org (Postfix, from userid 500) id CAD6C703E; Fri, 21 Jun 2002 02:00:22 +0200 (CEST) To: freebsd-stable@freebsd.org Subject: Re: ATA tags bug fix committed to -releng4 References: <20020620085158.K54942-100000@alexander.diva.nl> <030c01c21831$1ac8b320$0900a8c0@max> In-Reply-To: <030c01c21831$1ac8b320$0900a8c0@max> ("John Nielsen"'s message of "Thu, 20 Jun 2002 02:04:29 -0600") From: Matthias Andree Date: Fri, 21 Jun 2002 02:00:22 +0200 Message-ID: Lines: 25 User-Agent: Gnus/5.090007 (Oort Gnus v0.07) Emacs/21.1 (i686-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG "John Nielsen" writes: > I agree that merging minor bugfixes into a release branch is not good > practice. But if the ata fixes turn out to be not-so-minor, I wouldn't m= ind > seeing them go in in this case. IMHO, it qualifies as critical patch. Scenario: assume you're running 4.5-RELEASE-p, the "4.5 critical fixes" branch. Assume your /boot/loader.conf.local lists hw.ata.tags=3D"1". If you did now update to the "4.6 critical fixes" branch without this patch, your ATA stuff would break and let your Queued ("tags") enabled drives stall, and finally fall back to PIO after some retries, while 4.5 got it right. The trivial patch (it swaps two lines) reportedly fixes the regression that came with the MFC, and IMNSHO, PIO (without tags, tags require DMA) versus UDMA *does* matter. BTW, Thanks to S=F8ren for fixing this. --=20 Matthias Andree To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message