From owner-svn-src-all@freebsd.org Thu Apr 4 03:13:03 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 209DC155F700; Thu, 4 Apr 2019 03:13:03 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9535C81B69; Thu, 4 Apr 2019 03:13:02 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pl1-x633.google.com with SMTP id y6so423789plt.1; Wed, 03 Apr 2019 20:13:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=KSaijbsvaB27jWkVT1gl9Sj4P/b4NS6TB1BqPzF7iFc=; b=bMo0Yf+prVxebZJzeCuOQTjwMcvSm8lAGviQhpuNOm0gUq5OIeZrFEcpKDjSHh1e/l PdhA1F1LWVR/08L9oPMA2fXxoX7NHW0rbrHkeSpPiglmA7rLhaaMH5Bqi9VqNG+gKAAZ yk+wsBz4I3/ftql71PRfUeCAUNpa2wQrbsPMCaJf3HG4Xy7GSACMQTXAMkzCOI21g+MT KC3dXYWEL2AsiX8gJrlZNlEjXkTJq3MU+mX4oh79P9lRM9KDy0IAiZq5vlraWrZZ/pKY JDJEyq25A9tzJvvEmP0wmSIDi1DuO4rmSVNba+DvUMF4f6AmvzEXu2BX9Duz/SNT9pXH X08w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=KSaijbsvaB27jWkVT1gl9Sj4P/b4NS6TB1BqPzF7iFc=; b=iWnCPx2rCRz/yy1bwig5nuL/+RtjgAn1TiOMe0kWaZmU2X7Tc1LDJFvq9uduI4wC8l 8ZpBXeGuZskCxSiMjlrsMxrcu65+/NgiTcxhLGXPqx0Uujfz+WK/HilMqqJS2rx3GZQ9 gdIp/4yWBnlFTDPOgzc7t9mE1oY8KmkS2SH3odQ8m+CBc7p10LtsY1W/CEspm1rF7FYQ 6+0CCmQTn7Bl00ivInTMHBQwdbR/gk4zq8hHPSh3HGp90nXuq6Y+4y8X3srIcRbLeobz tLP07XDVMfOB4Fmd+ZHFWpsJn+HN3Vk8P1dXuvNUyfFIg2SuLu57943MN0Zt8Chr8VqC CvuA== X-Gm-Message-State: APjAAAXu1+1FKEKSDhG2fkQAZS6oXaIKVedks45su/nndm7S6poxZYGE zEsP3gsBaSwFw2uqvMbHON0ptESBz44= X-Google-Smtp-Source: APXvYqzO1Ije7TQCRmW2LB6jYdrA9oD+HzY/mEqYNpQHIyvVCEsSgnanL+ORURFivAeoH6lUPrYQtA== X-Received: by 2002:a17:902:9a0b:: with SMTP id v11mr3856175plp.194.1554347580813; Wed, 03 Apr 2019 20:13:00 -0700 (PDT) Received: from [192.168.20.7] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id u4sm52041299pgn.12.2019.04.03.20.12.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Apr 2019 20:13:00 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: svn commit: r345853 - head/usr.bin/rctl From: Enji Cooper In-Reply-To: <201904032037.x33KbEjq070604@repo.freebsd.org> Date: Wed, 3 Apr 2019 20:12:59 -0700 Cc: src-committers , svn-src-all , svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201904032037.x33KbEjq070604@repo.freebsd.org> To: Mateusz Guzik X-Mailer: Apple Mail (2.3445.102.3) X-Rspamd-Queue-Id: 9535C81B69 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.96)[-0.958,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Apr 2019 03:13:03 -0000 > On Apr 3, 2019, at 1:37 PM, Mateusz Guzik wrote: >=20 > Author: mjg > Date: Wed Apr 3 20:37:14 2019 > New Revision: 345853 > URL: https://svnweb.freebsd.org/changeset/base/345853 >=20 > Log: > rctl: fix sysctl kern.racct.enable use after r341182 >=20 > The value was changed from int to bool. Since the new type > is smaller, the rest of the variable in the caller was left > unitialized. I hit a bug like this recently with capsicum-test. Do you think it makes = sense to purge all of the memory or return -1/set EINVAL for reasons = similar to this for newp? [EINVAL] A non-null newp is given and its specified = length in newlen is too large or too small. Thanks! -Enji=