From owner-freebsd-gnome@freebsd.org Tue Apr 17 16:18:11 2018 Return-Path: Delivered-To: freebsd-gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 70F94F8776C for ; Tue, 17 Apr 2018 16:18:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 0B68D74B82 for ; Tue, 17 Apr 2018 16:18:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id BE4E2F8776A; Tue, 17 Apr 2018 16:18:10 +0000 (UTC) Delivered-To: gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 83D82F87769 for ; Tue, 17 Apr 2018 16:18:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2559974B7E for ; Tue, 17 Apr 2018 16:18:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 69F8428620 for ; Tue, 17 Apr 2018 16:18:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w3HGI9al080755 for ; Tue, 17 Apr 2018 16:18:09 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w3HGI9p7080754 for gnome@FreeBSD.org; Tue, 17 Apr 2018 16:18:09 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: [Bug 226920] devel/glib20: pull the latest file monitor fix from upstream Date: Tue, 17 Apr 2018 16:18:09 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: lantw44@gmail.com X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kwm@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 16:18:11 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D226920 --- Comment #16 from Ting-Wei Lan --- (In reply to lightside from comment #15) THere was an assertion failure in _kqsub_free on line 364: 360 static void 361 _kqsub_free (kqueue_sub *sub) 362 { 363 g_assert (sub->deps =3D=3D NULL); 364 g_assert (sub->fd =3D=3D -1); 365=20 366 g_source_unref ((GSource *) sub->source); 367 g_free (sub->filename); 368 g_slice_free (kqueue_sub, sub); 369 } _kqsub_free was called by g_kqueue_file_monitor_cancel on line 326. 323 if (kqueue_monitor->sub) 324 { 325 _kqsub_cancel (kqueue_monitor->sub); 326 _kqsub_free (kqueue_monitor->sub); 327 kqueue_monitor->sub =3D NULL; 328 } The previous function call, _kqsub_cancel, set sub->fd to -1 when it succee= ded. 371 static gboolean 372 _kqsub_cancel (kqueue_sub *sub) 373 { 374 struct kevent ev; 375=20 376 if (sub->deps) 377 { 378 dl_free (sub->deps); 379 sub->deps =3D NULL; 380 } 381=20 382 _km_remove (sub); 383=20 384 /* Only in the missing list? We're done! */ 385 if (sub->fd =3D=3D -1) 386 return TRUE; 387=20 388 EV_SET (&ev, sub->fd, EVFILT_VNODE, EV_DELETE, NOTE_ALL, 0, sub); 389 if (kevent (kq_queue, &ev, 1, NULL, 0, NULL) =3D=3D -1) 390 { 391 g_warning ("Unable to remove event for %s: %s", sub->filename, g_strerror (errno)); 392 return FALSE; 393 } 394=20 395 close (sub->fd); 396 sub->fd =3D -1; 397=20 398 return TRUE; 399 } For _kqsub_cancel to return without setting sub->fd to -1, it must return on line 392, which means the kevent call failed. --=20 You are receiving this mail because: You are on the CC list for the bug.=