From owner-svn-src-head@FreeBSD.ORG Thu Mar 12 23:45:35 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8227D1A4; Thu, 12 Mar 2015 23:45:35 +0000 (UTC) Received: from relay.mailchannels.net (ar-005-i205.relay.mailchannels.net [162.253.144.87]) by mx1.freebsd.org (Postfix) with ESMTP id D4E7AE1F; Thu, 12 Mar 2015 23:45:33 +0000 (UTC) X-Sender-Id: duocircle|x-authuser|hippie Received: from smtp5.ore.mailhop.org (ip-10-237-13-110.us-west-2.compute.internal [10.237.13.110]) by relay.mailchannels.net (Postfix) with ESMTPA id 9645A12066C; Thu, 12 Mar 2015 23:39:00 +0000 (UTC) X-Sender-Id: duocircle|x-authuser|hippie Received: from smtp5.ore.mailhop.org (smtp5.ore.mailhop.org [10.83.15.107]) (using TLSv1 with cipher DHE-RSA-AES256-SHA) by 0.0.0.0:2500 (trex/5.4.8); Thu, 12 Mar 2015 23:39:00 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: duocircle|x-authuser|hippie X-MailChannels-Auth-Id: duocircle X-MC-Loop-Signature: 1426203540706:3833725909 X-MC-Ingress-Time: 1426203540706 Received: from c-73-34-117-227.hsd1.co.comcast.net ([73.34.117.227] helo=ilsoft.org) by smtp5.ore.mailhop.org with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.82) (envelope-from ) id 1YWCgt-0000dF-SD; Thu, 12 Mar 2015 23:38:59 +0000 Received: from revolution.hippie.lan (revolution.hippie.lan [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t2CNcwjZ014979; Thu, 12 Mar 2015 17:38:58 -0600 (MDT) (envelope-from ian@freebsd.org) X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 73.34.117.227 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX19vSGsIRjT7bzGQurhTA4vi Message-ID: <1426203538.6265.6.camel@freebsd.org> Subject: Re: svn commit: r279934 - head/sys/dev/cxgbe From: Ian Lepore To: Navdeep Parhar Date: Thu, 12 Mar 2015 17:38:58 -0600 In-Reply-To: <5502191D.1010901@FreeBSD.org> References: <201503121822.t2CIML1c044098@svn.freebsd.org> <5502191D.1010901@FreeBSD.org> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.12.10 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-AuthUser: hippie Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Mar 2015 23:45:35 -0000 On Thu, 2015-03-12 at 15:54 -0700, Navdeep Parhar wrote: > On 03/12/2015 11:22, Ian Lepore wrote: > > Author: ian > > Date: Thu Mar 12 18:22:20 2015 > > New Revision: 279934 > > URL: https://svnweb.freebsd.org/changeset/base/279934 > > > > Log: > > Nullterminate strings returned via sysctl. > > > > PR: 195668 > > > > Modified: > > head/sys/dev/cxgbe/t4_l2t.c > > head/sys/dev/cxgbe/t4_main.c > > > > Modified: head/sys/dev/cxgbe/t4_l2t.c > > ============================================================================== > > --- head/sys/dev/cxgbe/t4_l2t.c Thu Mar 12 18:09:39 2015 (r279933) > > +++ head/sys/dev/cxgbe/t4_l2t.c Thu Mar 12 18:22:20 2015 (r279934) > > @@ -321,6 +321,7 @@ skip: > > mtx_unlock(&e->lock); > > } > > > > + sbuf_putc(&sb, 0); /* nullterm */ > > This breaks the build, please fix. > > Here's the relevant snippet from Jenkins: > > --- t4_l2t.o --- > :324:12: > error: incompatible pointer types passing 'struct sbuf **' to parameter > of type 'struct sbuf *'; remove & [-Werror,-Wincompatible-pointer-types] > sbuf_putc(&sb, 0); /* nullterm */ > ^~~ > :77:30: > note: passing argument to parameter here > int sbuf_putc(struct sbuf *, int); > ^ > 1 error generated. > *** [t4_l2t.o] Error code 1 > Ooops, sorry about that, I didn't notice the different levels of indirection in the two files and pasted the same line into both. -- Ian