From owner-freebsd-bugs@FreeBSD.ORG Tue Feb 16 19:18:57 2010 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 41E59106566B for ; Tue, 16 Feb 2010 19:18:57 +0000 (UTC) (envelope-from petefrench@ticketswitch.com) Received: from constantine.ticketswitch.com (constantine.ticketswitch.com [IPv6:2002:57e0:1d4e:1::3]) by mx1.freebsd.org (Postfix) with ESMTP id 039598FC14 for ; Tue, 16 Feb 2010 19:18:57 +0000 (UTC) Received: from dilbert.rattatosk ([10.64.50.6] helo=dilbert.ticketswitch.com) by constantine.ticketswitch.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.69 (FreeBSD)) (envelope-from ) id 1NhSwS-000Nkk-Uh; Tue, 16 Feb 2010 19:18:40 +0000 Received: from petefrench by dilbert.ticketswitch.com with local (Exim 4.71 (FreeBSD)) (envelope-from ) id 1NhSwS-0007lO-Ur; Tue, 16 Feb 2010 19:18:40 +0000 Date: Tue, 16 Feb 2010 19:18:40 +0000 Message-Id: To: yanefbsd@gmail.com In-Reply-To: <7d6fde3d1002161105m2842eda9rdbb6f04932dd1c64@mail.gmail.com> From: Pete French Cc: freebsd-bugs@freebsd.org Subject: Re: bin/131861: [patch] mail(1) misses addresses when replying to all X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2010 19:18:57 -0000 > Two dumb questions: > 1. Why isn't this checking for '\0'? It is - line 430 does it > 2. If there's a `"', shouldn't there be a terminating the end `"' > as well? It's a pretty blatant shell syntax error if that requirement > isn't met... Yes, but this is also handled elsewhere in the loop. My change to the 'if' doesnt detect a previously undetected quote, what it does is allow for there not being a space between the comma and the quote. Originally it took space-comma-quote, but now it takes space-quote as well. This is why the space eating while loop needed to be changed too, as it now needs to work for zero spaces. The rest of the fucntion has been in use for so long (decades?) that I am fairly sure it's correct as far as matching quotes and checking for zeros goes. I do not think the patch introduces any possibility of unmatched quotes, and I've been running with it for some time without incident. I would like someone else to check it out though, so thanks for taking a look. You're the first person to actually take an interest! cheers, -pete.