From owner-freebsd-arch@FreeBSD.ORG Fri Feb 10 16:52:44 2012 Return-Path: Delivered-To: freebsd-arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2E88A1065675; Fri, 10 Feb 2012 16:52:44 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id BB91B8FC12; Fri, 10 Feb 2012 16:52:43 +0000 (UTC) Received: from [10.30.101.53] ([209.117.142.2]) (authenticated bits=0) by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id q1AGjrAQ045973 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO); Fri, 10 Feb 2012 09:45:56 -0700 (MST) (envelope-from imp@bsdimp.com) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: <20120210110243.GA2012@lor.one-eyed-alien.net> Date: Fri, 10 Feb 2012 09:45:48 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <4996D1CF-25E5-4422-996C-DF23B5C10732@bsdimp.com> References: <20120131213857.86c81626.ray@ddteam.net> <20120210110243.GA2012@lor.one-eyed-alien.net> To: Brooks Davis X-Mailer: Apple Mail (2.1084) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (harmony.bsdimp.com [10.0.0.6]); Fri, 10 Feb 2012 09:45:57 -0700 (MST) Cc: Aleksandr Rybalko , freebsd-arch@FreeBSD.org Subject: Re: dynamic attach of hinted devices X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Feb 2012 16:52:44 -0000 On Feb 10, 2012, at 4:02 AM, Brooks Davis wrote: > On Tue, Jan 31, 2012 at 09:38:57PM +0200, Aleksandr Rybalko wrote: >> Hi FreeBSD hackers, >>=20 >> at first I want to say this: :) >> WARNING: FOLLOWING DEVCTL PATCH MAY EASILY PANIC YOUR SYSTEM, PLEASE >> DO NOT TRY IT ON PRODUCTION SERVERS AND TRY IT WITH FILESYSTEMS = MOUNTED >> AS READONLY :))))) >>=20 >> So I introduce two patches first one [1] used to migrate from >> static_hints or hints in the static_kenv to dynamic hints. >>=20 >> sysctl kern.hintmode=3D2 will copy hints from static hints or from = static >> kenv and put it into dynamic kenv. Those will allow to manipulate = hints >> values and attach hinted devices with devctl tool. >>=20 >> Second [2] allow attach/detach devices with userland tool devctl. >>=20 >> devctl tool allow add and initialize new devices which is not able to >> be autoenumerating, such a hinted devices. >>=20 >> Both designed to have ability update EEPROM items in runtime, since >> some device can't work in mode when it accessible like a EEPROM chip. >>=20 >> Example: >> # sysctl kern.hintmode=3D2 >> # kenv hint.mx25l.0.at=3D"spibus0" >> # kenv hint.mx25l.0.cs=3D0 >> # kenv hint.mx25l.0.chipname=3D"at25128" >> # devctl hinted spibus 0 mx25l 0 >> mx25l0: at cs 0 mode 0 on spibus0 >> mx25l0: at25128, sector 64 bytes, 256 sectors >> GEOM: new disk flash/spi0 >>=20 >> Someone may found it also useful for testing device attach/detach = code >> (memory leaks, resource allocation, etc). >>=20 >> So, say me please your opinion. >=20 > I skimmed over the patch and the concept looks good to me. I'm = probably > not the right person to review this proposal in detail, but perhaps = John > Baldwin (cc'd) could do it or suggest someone. I've looked at it and it looks OK, but I had lots of feedback I didn't = have time to write up. I like the concept, but have lots of suggestions = for improvement since I'd like to see this more generically done. Warner=