From owner-cvs-src@FreeBSD.ORG Thu Jul 8 17:05:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 752E216A4CE; Thu, 8 Jul 2004 17:05:26 +0000 (GMT) Received: from dong.ci0.org (cognet.ci0.org [80.65.224.102]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3E0AB43D5E; Thu, 8 Jul 2004 17:05:25 +0000 (GMT) (envelope-from doginou@dong.ci0.org) Received: from dong.ci0.org (localhost.ci0.org [127.0.0.1]) by dong.ci0.org (8.12.11/8.12.11) with ESMTP id i68HN2Mb087506; Thu, 8 Jul 2004 19:23:02 +0200 (CEST) (envelope-from doginou@dong.ci0.org) Received: (from doginou@localhost) by dong.ci0.org (8.12.11/8.12.11/Submit) id i68HN1mc087505; Thu, 8 Jul 2004 19:23:01 +0200 (CEST) (envelope-from doginou) Date: Thu, 8 Jul 2004 19:23:01 +0200 From: Olivier Houchard To: Brian Somers Message-ID: <20040708172301.GA86776@ci0.org> References: <200407081340.i68DeX0j013960@repoman.freebsd.org> <20040708175315.60f4577a@dev.lan.Awfulhak.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040708175315.60f4577a@dev.lan.Awfulhak.org> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha autoconf.c src/sys/amd64/amd64 autoconf.c src/sys/boot/common dev_net.c loader.8 src/sys/boot/forth loader.conf src/sys/conf NOTES files options src/sys/i386/i386 autoconf.c locore.s src/sys/ia64/ia64 autoconf.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jul 2004 17:05:26 -0000 On Thu, Jul 08, 2004 at 05:53:15PM +0100, Brian Somers wrote: > On Thu, 8 Jul 2004 13:40:33 +0000 (UTC), Brian Somers wrote: > > brian 2004-07-08 13:40:33 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/alpha/alpha autoconf.c > > sys/amd64/amd64 autoconf.c > > sys/boot/common dev_net.c loader.8 > > sys/boot/forth loader.conf > > sys/conf NOTES files options > > sys/i386/i386 autoconf.c locore.s > > sys/ia64/ia64 autoconf.c > > sys/modules/nfs4client Makefile > > sys/modules/nfsclient Makefile > > sys/netinet ip_input.c > > sys/nfs4client nfs4_vfsops.c > > sys/nfsclient bootp_subr.c nfs_vfsops.c > > Log: > > Change the following kernel options to environment variables: > > > > BOOTP -> bootp > > BOOTP_NFSROOT -> bootp.nfsroot > > BOOTP_NFSV3 -> bootp.nfsv3 > > BOOTP_COMPAT -> bootp.compat > > BOOTP_WIRED_TO -> bootp.wired_to > > > > This lets you PXE boot with a GENERIC kernel by putting this sort of thing > > in loader.conf: > > > > bootp="YES" > > bootp.nfsroot="YES" > > bootp.nfsv3="YES" > > bootp.wired_to="bge1" > > > > or even setting the variables manually from the OK prompt. > > > > Revision Changes Path > > 1.58 +6 -6 src/sys/alpha/alpha/autoconf.c > > 1.179 +11 -8 src/sys/amd64/amd64/autoconf.c > > 1.14 +1 -1 src/sys/boot/common/dev_net.c > > 1.63 +23 -0 src/sys/boot/common/loader.8 > > 1.81 +5 -0 src/sys/boot/forth/loader.conf > > 1.1242 +1 -8 src/sys/conf/NOTES > > 1.924 +2 -2 src/sys/conf/files > > 1.461 +0 -5 src/sys/conf/options > > 1.176 +11 -8 src/sys/i386/i386/autoconf.c > > 1.183 +0 -3 src/sys/i386/i386/locore.s > > 1.18 +10 -13 src/sys/ia64/ia64/autoconf.c > > 1.2 +1 -1 src/sys/modules/nfs4client/Makefile > > 1.28 +1 -1 src/sys/modules/nfsclient/Makefile > > 1.276 +6 -5 src/sys/netinet/ip_input.c > > 1.8 +0 -1 src/sys/nfs4client/nfs4_vfsops.c > > 1.59 +80 -76 src/sys/nfsclient/bootp_subr.c > > 1.154 +11 -5 src/sys/nfsclient/nfs_vfsops.c > > Hmm, so as dwmalone@ has pointed out, this stuff just works even without > any of the bootp stuff when you PXE boot. > > Thinking out loud, I now suspect that the only reason it was really necessary > to have BOOTP_* configured into a kernel before this commit is if you don't > have pxeboot(8) or loader(8). > > Is there anybody out there that uses the BOOTP* options that can confirm this ? > Do I need to back out this commit ? > Hi, Speaking for myself, I do not use this stuff yet, but plan to do so later, because I probably won't have any support from the loader at all, so if nobody has a strong objection, I'd like to see this backed out. Thanks, Olivier