From owner-svn-src-all@FreeBSD.ORG Tue Nov 26 16:19:09 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 795F78D2; Tue, 26 Nov 2013 16:19:09 +0000 (UTC) Received: from mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9A76C2A7F; Tue, 26 Nov 2013 16:19:08 +0000 (UTC) Received: from r2d2 ([82.69.179.241]) by mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23]) (MDaemon PRO v10.0.4) with ESMTP id md50006841784.msg; Tue, 26 Nov 2013 16:19:04 +0000 X-Spam-Processed: mail1.multiplay.co.uk, Tue, 26 Nov 2013 16:19:04 +0000 (not processed: message from valid local sender) X-MDDKIM-Result: neutral (mail1.multiplay.co.uk) X-MDRemoteIP: 82.69.179.241 X-Return-Path: prvs=1042f5e7dd=killing@multiplay.co.uk X-Envelope-From: killing@multiplay.co.uk Message-ID: <54A7475886594221ABD007A86649441D@multiplay.co.uk> From: "Steven Hartland" To: "Andriy Gapon" , , , References: <201311260957.rAQ9vF6d004168@svn.freebsd.org> <5294A0CD.8030000@FreeBSD.org> Subject: Re: svn commit: r258632 - in head: cddl/contrib/opensolaris/cmd/ztest cddl/contrib/opensolaris/lib/libzpool/common/sys sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys... Date: Tue, 26 Nov 2013 16:18:57 -0000 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="utf-8"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Nov 2013 16:19:09 -0000 ----- Original Message ----- From: "Andriy Gapon" > on 26/11/2013 14:34 Steven Hartland said the following: >> Can I ask why choose priority now for TRIM, does this not change the flow of >> free requests quite significantly? > > Sorry, I couldn't grok the question... > Also, please take into account that I know nothing about TRIM nor TRIM + ZFS. > > BTW, I appreciate the review but a timely review[*] would be appreciated even > more :-) Erm did I miss something, this only got commited a few hours ago which is the first I knew about it. Did you ask for reviews somewhere I'm not aware of? >> Also as we have rotational information available should we apply >> the following change which makes the active queue timestamp sorted >> instead of offset sorted? >> >> An AVL as a FIFO queue seems like quite an expensive option. > > I've just merged the upstream change, perhaps badly. > Any improvement are appreciated. Will look in more depth at this one as it touches the mirror code I commited recently. Regards Steve ================================================ This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it. In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337 or return the E.mail to postmaster@multiplay.co.uk.