From owner-cvs-ports@FreeBSD.ORG  Tue Jul  5 15:04:28 2011
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1AC3F106566B;
	Tue,  5 Jul 2011 15:04:28 +0000 (UTC)
	(envelope-from pgollucci@p6m7g8.com)
Received: from EXHUB015-3.exch015.msoutlookonline.net
	(exhub015-3.exch015.msoutlookonline.net [207.5.72.95])
	by mx1.freebsd.org (Postfix) with ESMTP id 00D758FC13;
	Tue,  5 Jul 2011 15:04:27 +0000 (UTC)
Received: from philip.hq.rws (174.79.184.239) by smtpx15.msoutlookonline.net
	(207.5.72.103) with Microsoft SMTP Server (TLS) id 8.2.254.0;
	Tue, 5 Jul 2011 08:04:28 -0700
Message-ID: <4E1327FA.9090602@p6m7g8.com>
Date: Tue, 5 Jul 2011 15:04:26 +0000
From: "Philip M. Gollucci" <pgollucci@p6m7g8.com>
Organization: P6M7G8 Inc.
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.1.16) Gecko/20110507 Thunderbird/3.0.11
MIME-Version: 1.0
To: Alexey Dokuchaev <danfe@FreeBSD.org>
References: <201106271435.p5REZYab035297@repoman.freebsd.org>
	<20110705141333.GA23300@FreeBSD.org>
In-Reply-To: <20110705141333.GA23300@FreeBSD.org>
X-Enigmail-Version: 1.0.1
Content-Type: text/plain; charset="KOI8-R"
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org, cvs-all@FreeBSD.org,
	Martin Wilke <miwi@FreeBSD.org>
Subject: Re: cvs commit: ports/devel Makefile ports/devel/libestr Makefile
 distinfo pkg-descr pkg-plist ports/devel/libestr/files patch-Makefile.in
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jul 2011 15:04:28 -0000

Yes, I'm supposed to be the maintainer b/c these ports are only used by
rsyslog6-devel and I'm the maintainer of that stack.  I had an e-mail
conversation with the submitter.  miwi just took the pr instantly.  I
did no review on the ports though b/c I didn't commit them.

On 07/05/11 14:13, Alexey Dokuchaev wrote:
> On Mon, Jun 27, 2011 at 02:35:34PM +0000, Martin Wilke wrote:
>> miwi        2011-06-27 14:35:34 UTC
>>
>>   Modified files:
>>     devel                Makefile 
>>   Added files:
>>     devel/libestr        Makefile distinfo pkg-descr pkg-plist 
>>     devel/libestr/files  patch-Makefile.in 
>>   Log:
>>   A library for some string essentials.
> 
> This description (= pkg-descr) is very short and uninformative.  Also, the
> port has other issues:
> 
> - Does pgollucci@ know and approve that he's listed as maintainer?
> - Bogus CONFIGURE_ARGS indentation; also --prefix="${PREFIX}" is redundant
>   since GNU_CONFIGURE is used
> - Tab instead of space after WWW: line in pkg-descr
> 
> ./danfe


-- 
------------------------------------------------------------------------
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70  3F8C 75B8 8FFB DB9B 8C1C
Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354
VP Infrastructure,                Apache Software Foundation
Committer,                        FreeBSD Foundation
Consultant,                       P6M7G8 Inc.
Sr. System Admin,                 Ridecharge Inc.

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.