From owner-p4-projects@FreeBSD.ORG  Wed Nov 19 19:17:27 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id A62FC106568C; Wed, 19 Nov 2008 19:17:27 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 67B661065680
	for <perforce@freebsd.org>; Wed, 19 Nov 2008 19:17:26 +0000 (UTC)
	(envelope-from csjp@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 577178FC08
	for <perforce@freebsd.org>; Wed, 19 Nov 2008 19:17:26 +0000 (UTC)
	(envelope-from csjp@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id mAJJHQuD052804
	for <perforce@freebsd.org>; Wed, 19 Nov 2008 19:17:26 GMT
	(envelope-from csjp@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id mAJJHQ30052802
	for perforce@freebsd.org; Wed, 19 Nov 2008 19:17:26 GMT
	(envelope-from csjp@freebsd.org)
Date: Wed, 19 Nov 2008 19:17:26 GMT
Message-Id: <200811191917.mAJJHQ30052802@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	csjp@freebsd.org using -f
From: "Christian S.J. Peron" <csjp@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 153232 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2008 19:17:28 -0000

http://perforce.freebsd.org/chv.cgi?CH=153232

Change 153232 by csjp@hvm02 on 2008/11/19 19:17:14

	Mark internal functions as static, create prototypes for the
	methods that will be consumed by external code.  Add a comment
	that we will require an eviction staregy when we are adding the
	cache entry.

Affected files ...

.. //depot/projects/trustedbsd/bsmtrace/fcache.c#3 edit
.. //depot/projects/trustedbsd/bsmtrace/fcache.h#2 edit
.. //depot/projects/trustedbsd/bsmtrace/includes.h#3 edit

Differences ...

==== //depot/projects/trustedbsd/bsmtrace/fcache.c#3 (text+ko) ====

@@ -28,7 +28,6 @@
  * SUCH DAMAGE.
  */
 #include "includes.h"
-#include "fcache.h"
 
 static int      fcache_cmp(struct fcache *, struct fcache *);
 
@@ -72,7 +71,7 @@
 	TAILQ_INIT(&cache_head);
 }
 
-struct dev_list *
+static struct dev_list *
 fcache_locate(dev_t device)
 {
 	struct dev_list *dp;
@@ -104,12 +103,15 @@
 	return (fcp->f_pathname);
 }
 
-static void
+void
 fache_add_entry(dev_t device, ino_t inode, char *pathname)
 {
 	struct dev_list *dp;
 	struct fcache *fcp;
 
+	/*
+	 * NB: We need an eviction strategy here.
+	 */
 	dp = fcache_locate(device);
 	if (dp == NULL) {
 		(void) fprintf(stderr, "failed to allocate cache\n");

==== //depot/projects/trustedbsd/bsmtrace/fcache.h#2 (text+ko) ====

@@ -42,4 +42,9 @@
 	RB_HEAD(btree, fcache)	d_btree;
 };
 
+void		 fcache_destroy(void);
+void		 fcache_init(void);
+char		*fcache_search(dev_t, ino_t);
+void		 fache_add_entry(dev_t, ino_t, char *);
+
 #endif	/* FCACHE_DOT_H_ */

==== //depot/projects/trustedbsd/bsmtrace/includes.h#3 (text+ko) ====

@@ -30,6 +30,7 @@
 #include <sys/types.h>
 #ifndef __APPLE__
 #include <sys/queue.h>
+#include <sys/tree.h>
 #endif
 #include <sys/stat.h>
 #include <sys/param.h>
@@ -67,6 +68,7 @@
 #endif
 #include "config.h"
 #include "deuce.h"
+#include "fcache.h"
 #include "bsmtrace.h"
 #include "conf.h"
 #include "bsm.h"