From owner-dev-commits-src-all@freebsd.org Wed Jan 6 17:03:07 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9B9E04D703A; Wed, 6 Jan 2021 17:03:07 +0000 (UTC) (envelope-from brd@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D9wfg3swKz4ZSj; Wed, 6 Jan 2021 17:03:07 +0000 (UTC) (envelope-from brd@FreeBSD.org) Received: from auth1-smtp.messagingengine.com (auth1-smtp.messagingengine.com [66.111.4.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: brd/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 71232BDA4; Wed, 6 Jan 2021 17:03:07 +0000 (UTC) (envelope-from brd@FreeBSD.org) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id 3019827C0054; Wed, 6 Jan 2021 12:03:07 -0500 (EST) Received: from imap2 ([10.202.2.52]) by compute4.internal (MEProxy); Wed, 06 Jan 2021 12:03:07 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdegtddgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfgjfhffhffvufgtsehttd ertderreejnecuhfhrohhmpedfuehrrgguucffrghvihhsfdcuoegsrhgusefhrhgvvgeu ufffrdhorhhgqeenucggtffrrghtthgvrhhnpeevhfdvueejledthfehvdduhfdvhfetie evtedtueelkedugfelleffgfegtdfhveenucffohhmrghinhepfhhrvggvsghsugdrohhr ghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegsrh grugdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqjedtjeeifedvfedvqddu kedtieelieekkedqsghrugeppefhrhgvvgeuufffrdhorhhgsehsohdugehkrdgtohhm X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id A1B13E00A6; Wed, 6 Jan 2021 12:03:04 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.3.1-61-gb52c239-fm-20201210.001-gb52c2396 Mime-Version: 1.0 Message-Id: In-Reply-To: <202101060736.1067aB81077326@gitrepo.freebsd.org> References: <202101060736.1067aB81077326@gitrepo.freebsd.org> Date: Wed, 06 Jan 2021 10:02:45 -0700 From: "Brad Davis" To: "Mateusz Guzik" , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: =?UTF-8?Q?Re:_git:_deabdc686874_-_main_-_cache:_stop_pre-checking_seqc_w?= =?UTF-8?Q?hen_starting_the_lookup?= Content-Type: text/plain X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2021 17:03:07 -0000 On Wed, Jan 6, 2021, at 12:36 AM, Mateusz Guzik wrote: > The branch main has been updated by mjg: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=deabdc686874411bd32775c3bdd04c04d9eff3e5 > > commit deabdc686874411bd32775c3bdd04c04d9eff3e5 > Author: Mateusz Guzik > AuthorDate: 2021-01-06 06:12:58 +0000 > Commit: Mateusz Guzik > CommitDate: 2021-01-06 07:28:07 +0000 > > cache: stop pre-checking seqc when starting the lookup > > Tested by: pho > --- > sys/kern/vfs_cache.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c > index 710c499d6bb5..138a55f94dbd 100644 > --- a/sys/kern/vfs_cache.c > +++ b/sys/kern/vfs_cache.c > @@ -5032,7 +5032,7 @@ cache_fplookup_skip_slashes(struct cache_fpl *fpl) > ndp->ni_next = cnp->cn_nameptr; > > /* > - * Retry the lookup, similar to dot lookups. > + * See cache_fplookup_dot. > */ > fpl->tvp = fpl->dvp; > fpl->tvp_seqc = fpl->dvp_seqc; > @@ -5139,11 +5139,14 @@ cache_fplookup_impl(struct vnode *dvp, struct > cache_fpl *fpl) > > cache_fpl_checkpoint(fpl, &fpl->snd); > > + /* > + * The vnode is hand is almost always stable, skip checking for it. "The vnode in hand" maybe? Regards, Brad Davis