From nobody Tue Sep 19 23:15:17 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RqyF31gmsz4t8Rn for ; Tue, 19 Sep 2023 23:15:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RqyF24p3Cz4L5J for ; Tue, 19 Sep 2023 23:15:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695165318; a=rsa-sha256; cv=none; b=YG6RYxpxwosU9vAV1FXqS5mbZE0hACK27wOfObNtinLISn/5R2t7P2Ts9e252ym7tJfKtK GD/aW+D7+bkhupRw4U0ptG00dCUDEEYopiGf73F2yjKTnsDW8iFMpF3YFDB8F/U7mEZzqM YemOxB4P4KVLiLP88/9ASNgt7DdW/r+h/3zD6dkHouS2LTwEycPuvd+sTfPPlP32m1pnbE B/cgTjOr1AB/npN77lLmF6Xtsj0ZYCpUJkVuc+y3at2hBoH2oPbNrnTfLoNkSmOLS+iBi9 4qLU/SeC/LebfHgXkg5suDTjAlS8VSHbpWz6X+ekacsX94cTbdUDr+UjYl/MjA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695165318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AFN9OrNH955UVWkjhM3qBoJYsF28McO+9e7e2uOt3No=; b=Ha4S+L/l1DyKAVovsAliyR0F+jDq9Vqg3mHSheItTRwyf8q9jshBQsBLQdHI2z89K4BCL0 jCmxpEV5N4kX+r2tGTIIIyJdhNPnBm5kMhzaw4vsovyPQPp5pKhGa0nM37gwEz5fhARQMU xAnuMcQ2gBkhz1rXceT/BPMp+PxwJwveAiSqgOB2MUeVIyXePDvhG5bOU3gRdbnrL7x3T6 /vvQPxxG3I5jY1P6B8ogJjeOQHkLYNkDr6p/txjomoH1osKoanAlMQ2mozu8OJCf5s+v1I v2a1/tN9D3XybdUb7nrexokRFPsf4Is/bsiWDfTfW7SjK9YeVjTFa2MupFxhdw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RqyF20p7CzY52 for ; Tue, 19 Sep 2023 23:15:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 38JNFIVU009290 for ; Tue, 19 Sep 2023 23:15:18 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 38JNFI5Q009289 for ports-bugs@FreeBSD.org; Tue, 19 Sep 2023 23:15:18 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 273951] multimedia/streamlink: incorrect dependencies Date: Tue, 19 Sep 2023 23:15:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: mail@bastimeyer.de X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273951 Bug ID: 273951 Summary: multimedia/streamlink: incorrect dependencies Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: mail@bastimeyer.de CC: takefu@airport.fm CC: takefu@airport.fm Flags: maintainer-feedback?(takefu@airport.fm) Hi, I'm the developer of Streamlink and I've noticed some issues with the Makefile of FreeBSD's Streamlink port. I'm not a FreeBSD user, so I don't want to submit a patch which I haven't tested/validated. Instead, I will just point out some issues and hope that someone else can have a quick look. Sorry about that. I've tried to reach out to the port's maintainer, but their email server rejected my email from earlier today for some reason, which is why I'm open= ing this bug report instead. ---- Here are the issues: 1. The Makefile defines RTMPDUMP as a runtime dependency. RTMPdump has been dropped in Streamlink's 3.0.0 release a long time ago: - https://streamlink.github.io/changelog.html#streamlink-3-0-0-2021-11-17 - https://github.com/freebsd/freebsd-ports/blob/1126b37ed2e374cda426d3a82e08c= 77f4b9ffad5/multimedia/streamlink/Makefile#L39-L42 2. While `py-trio-websocket` was correctly added as a dependency after the = 6.x bump, `py-trio` was not for some reason. Even if it's a dependency of `py-trio-websocket`, it's a direct dependency of Streamlink and thus not a transitive dependency. If Streamlink defines version constraints for its di= rect dependencies, then the Makefile is lacking those constraints, so direct dependencies should always be added: - https://github.com/freebsd/freebsd-ports/blob/1126b37ed2e374cda426d3a82e08c= 77f4b9ffad5/multimedia/streamlink/Makefile#L24 3. Same issue with `urllib3`, which is a direct dependency of Streamlink, n= ot a transitive dependency via `requests`: - https://github.com/freebsd/freebsd-ports/blob/1126b37ed2e374cda426d3a82e08c= 77f4b9ffad5/multimedia/streamlink/Makefile#L23 4. The Python version constraint seems to have been removed recently. As sa= id, I'm not a FreeBSD user, so I don't know anything about the availability of specific Python versions. Streamlink 6.0.0 requires Python >=3D3.8: - https://github.com/freebsd/freebsd-ports/commit/5f4256e50c2285e70f70ed96520= 76e01945e103d 5. flake8 is not a test dependency of Streamlink: - https://github.com/freebsd/freebsd-ports/blob/1126b37ed2e374cda426d3a82e08c= 77f4b9ffad5/multimedia/streamlink/Makefile#L28 6. Streamlink 6.0.0 has dropped support for Python 3.7 and has thus dropped= all compatibility dependencies, including the mock test dependency: - https://github.com/freebsd/freebsd-ports/blob/1126b37ed2e374cda426d3a82e08c= 77f4b9ffad5/multimedia/streamlink/Makefile#L30 ---- The latest release is 6.2.0 from 2023-09-14. Here are the latest build+runtime and test dependencies: - https://github.com/streamlink/streamlink/blob/6.2.0/pyproject.toml#L3-L7 - https://github.com/streamlink/streamlink/blob/6.2.0/pyproject.toml#L50-L64 - https://github.com/streamlink/streamlink/blob/6.2.0/dev-requirements.txt#L5= -L10 ---- Thanks --=20 You are receiving this mail because: You are the assignee for the bug.=