Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 10 Mar 2005 20:23:59 +0100
From:      Florent Thoumie <flz@FreeBSD.org>
To:        Adam Weinberger <adamw@FreeBSD.org>
Cc:        ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/net/rdesktop pkg-plist
Message-ID:  <42309ECF.1090306@FreeBSD.org>
In-Reply-To: <20050310191906.GG48850@toxic.magnesium.net>
References:  <200503101905.j2AJ5B6R013928@repoman.freebsd.org> <42309B5B.7020201@FreeBSD.org> <20050310191906.GG48850@toxic.magnesium.net>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig4E53C3A9D82CCAD589BE5EA8
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Adam Weinberger wrote:
>>>(03.10.2005 @ 1409 PST): Florent Thoumie said, in 1.2K: <<
>>
>>David E. O'Brien wrote:
>>
>>>obrien      2005-03-10 19:05:11 UTC
>>>
>>> FreeBSD ports repository
>>>
>>> Modified files:
>>>   net/rdesktop         pkg-plist
>>> Log:
>>> Sort the keymaps.
>>>
>>> Revision  Changes    Path
>>> 1.5       +32 -32    ports/net/rdesktop/pkg-plist
>>
>>	This is your third commit to get rdesktop updated
>>	in two days.
>>
>>	There was a PR pending with a patch included. Maintainer
>>	has been cc'ed.
>>
>>	Please respect ownership when not working on your ports,
>>	or at least wait for maintainer timeout before applying
>>	your changes.
>>
>>>end of "Re: cvs commit: ports/net/rdesktop pkg-plist" from Florent Thoumie <<
>
>
> Sorting the pkg-plist is a trivial change, and was the maintainer's
> responsibility in the first place. Asking for maintainer approval
> for trivial fixes supports a level of bureaucracy that, while nice
> in concept, simple prevents people from applying trivial fixes.

	I'm ok, not talking about just sorting the packing list.

> Note that I'm not commenting on David's other commits to rdesktop;
> I haven't looked at them. Note also that I do not know what is in
> the PR. My only argument here is that committers should not feel
> like applying trivial fixes and routine maintenance to the ports
> tree amounts to stepping on someone's toes.

	He might be very familiar with this port, I really don't
	know, but I've even seen discussions about security updates
	where maintainer rejected submitted patches. That's their
	right.

	The only fact that a PR about rdesktop was in feedback state
	should prevent him from just committing an update.

	My 2 (new committer's and maintainer's) cents.

--------------enig4E53C3A9D82CCAD589BE5EA8
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (FreeBSD)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCMJ7TMxEkbVFH3PQRAhswAJwNL4Q5Tq6rBspbJGNMq+Er6U2vywCffV5B
eDt7gX420UNlIw9/F6QaGEk=
=VFQ+
-----END PGP SIGNATURE-----

--------------enig4E53C3A9D82CCAD589BE5EA8--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?42309ECF.1090306>