From owner-freebsd-standards@FreeBSD.ORG  Fri Jul 12 17:13:59 2013
Return-Path: <owner-freebsd-standards@FreeBSD.ORG>
Delivered-To: freebsd-standards@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 673E1AFA;
 Fri, 12 Jul 2013 17:13:59 +0000 (UTC)
 (envelope-from swhetzel@gmail.com)
Received: from mail-ie0-x232.google.com (mail-ie0-x232.google.com
 [IPv6:2607:f8b0:4001:c03::232])
 by mx1.freebsd.org (Postfix) with ESMTP id 10CBE1118;
 Fri, 12 Jul 2013 17:13:59 +0000 (UTC)
Received: by mail-ie0-f178.google.com with SMTP id u16so21061158iet.37
 for <multiple recipients>; Fri, 12 Jul 2013 10:13:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=QiisUPirFKoVMBGknphIrRZc1nDMAFRG3tSIkRd6f4A=;
 b=vxMm7x7CcKMfsBiyJzfiOWrjLS025G2jU91bPy+W96nfW9qdCgS9Xw2/DSv+X0SCDb
 goeFjw/mOmVXX3usiEu1nAVePgNC1I6223OMcOpKWPqRzWc5q7PVNFI0+QYFGlg3kUZC
 ggLyEeaIXiPbojCUchcVEYkwn7v5YnqwoP7UN+H/MgQgcHRkgt2m0J+I5DYPwVVHkVcN
 Ct6HMwonTcyBHk8P4lQYoYdW41t6zF9dc10dOCjRECmfC1YjXNVjM6BND8Jsioc5WHRz
 Qv1suFDojub+xZ9OagB/FmqcP18QB1oBMnyH3u2o2XKuXpKxm6YymlcvdN1sUjCXdNRd
 mSzA==
MIME-Version: 1.0
X-Received: by 10.50.67.43 with SMTP id k11mr1242994igt.26.1373649238734; Fri,
 12 Jul 2013 10:13:58 -0700 (PDT)
Received: by 10.50.221.179 with HTTP; Fri, 12 Jul 2013 10:13:58 -0700 (PDT)
In-Reply-To: <CACdU+f9RmwxSiMEjOwSXHtnDwKk4xY8fmA3aBE5mzrVUkrc1Nw@mail.gmail.com>
References: <20130710155809.0f589c22@thor.walstatt.dyndns.org>
 <CD51F125-AE9E-4461-916D-CF583002B47D@FreeBSD.org>
 <20130710183315.725dfde0@thor.walstatt.dyndns.org>
 <C8C94CF2-7D5A-471B-AD63-8E961AED6274@FreeBSD.org>
 <20130710203200.5359fd18@thor.walstatt.dyndns.org>
 <51DDC04B.6040209@FreeBSD.org>
 <20957.49978.73666.392417@khavrinen.csail.mit.edu>
 <20130711130043.R920@besplex.bde.org>
 <FD768A6B-8B72-44A1-BC1C-14FF44CB4643@FreeBSD.org>
 <20130711202908.L84170@besplex.bde.org>
 <C00DFA94-6182-4334-9C90-8012E576E475@FreeBSD.org>
 <CACdU+f9RmwxSiMEjOwSXHtnDwKk4xY8fmA3aBE5mzrVUkrc1Nw@mail.gmail.com>
Date: Fri, 12 Jul 2013 12:13:58 -0500
Message-ID: <CACdU+f-LKsHsPayUYAT-cip91O=CfQg2aJ1BKC5PRd6G9Kf28w@mail.gmail.com>
Subject: Re: CURRENT: CLANG 3.3 and -stad=c++11 and -stdlib=libc++:
 isnan()/isninf() oddity
From: Scot Hetzel <swhetzel@gmail.com>
To: David Chisnall <theraven@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: FreeBSD CURRENT <freebsd-current@freebsd.org>,
 Garrett Wollman <wollman@csail.mit.edu>,
 "freebsd-toolchain@FreeBSD.org" <freebsd-toolchain@freebsd.org>,
 Tijl Coosemans <tijl@freebsd.org>,
 "freebsd-standards@FreeBSD.org" <freebsd-standards@freebsd.org>
X-BeenThere: freebsd-standards@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Standards compliance <freebsd-standards.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-standards>, 
 <mailto:freebsd-standards-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-standards>
List-Post: <mailto:freebsd-standards@freebsd.org>
List-Help: <mailto:freebsd-standards-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-standards>, 
 <mailto:freebsd-standards-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Jul 2013 17:13:59 -0000

On Fri, Jul 12, 2013 at 11:16 AM, Scot Hetzel <swhetzel@gmail.com> wrote:
> On Thu, Jul 11, 2013 at 9:33 AM, David Chisnall <theraven@freebsd.org> wrote:
>> On 11 Jul 2013, at 13:11, Bruce Evans <brde@optusnet.com.au> wrote:
>>
>>> The error message for the __builtin_isnan() version is slightly better up
>>> to where it says more.
>>>
>>> The less-unportable macro can do more classification and detect problems
>>> at compile time using __typeof().
>>
>> The attached patch fixes the related test cases in the libc++ test suite.  Please review.
>>
>
>  #define        fpclassify(x) \
> -    ((sizeof (x) == sizeof (float)) ? __fpclassifyf(x) \
> -    : (sizeof (x) == sizeof (double)) ? __fpclassifyd(x) \
> -    : __fpclassifyl(x))
> +        __fp_type_select(x, __fpclassifyf, __fpclassifyd, __fpclassifyd)
>
> The last __fpclassifyd should be __fpclassifyl.
>
I see it has already been fixed.


-- 
DISCLAIMER:

No electrons were maimed while sending this message. Only slightly bruised.