Date: Thu, 28 Sep 2023 02:16:12 +0000 From: bugzilla-noreply@freebsd.org To: chromium@FreeBSD.org Subject: maintainer-feedback requested: [Bug 274139] www/chromium: fails to build in stable/12 because EAI_NODATA is not defined Message-ID: <bug-274139-28929-Enzzmwmm0Q@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-274139-28929@https.bugs.freebsd.org/bugzilla/> References: <bug-274139-28929@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-chromium (Nobo= dy) <chromium@FreeBSD.org> for maintainer-feedback: Bug 274139: www/chromium: fails to build in stable/12 because EAI_NODATA is= not defined https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274139 --- Description --- Please refer to the email thread starting with https://lists.freebsd.org/archives/freebsd-ports/2023-September/004433.html >From the poudriere build log on my build machine, running: FreeBSD 12.4-STABLE #256 stable/12-n236282-b083794291d2: Wed Sep 27 10:26:39 UTC 2023=20=20=20=20 root@freebeast.catwhisker.org:/common/S1/obj/usr/src/amd64.amd64/sys/GENERI= C=20 amd64 1204500 1204500 with the ports tree at main-n634807-080478034ac8: FAILED: obj/net/dns/dns/address_info.o c++ -MMD -MF obj/net/dns/dns/address_info.o.d -DUSE_AURA=3D1 -DUSE_GLIB=3D1 -DUSE_OZONE=3D1 -DOFFICIAL_BUILD -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_M= ACROS -D_FORTIFY_SOURCE=3D2 -D_FILE_OFFSET_BITS=3D64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -D_GNU_SOURCE -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=3D0 -DGLIB_VERSION_MAX_ALLOWED=3DGLIB_VERSION= _2_56 -DGLIB_VERSION_MIN_REQUIRED=3DGLIB_VERSION_2_56 -DBASE_USE_PERFETTO_CLIENT_LIBRARY=3D1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DGOOGLE_PROTOBUF_INTERNAL_DONATE_STEAL_INLINE=3D0 -DHAVE_PTHREAD -DUSE_SYSTEM_LIBEVENT=3D1 -DNET_IMPLEMENTATION -DENABLE_BUILT_IN_DNS -DUSE_= GIO -DUSING_SYSTEM_ICU=3D1 -DICU_UTIL_DATA_IMPL=3DICU_UTIL_DATA_STATIC -DU_FINA= L=3Dfinal -DU_NOEXCEPT=3Dnoexcept -DU_OVERRIDE=3Doverride -DU_IMPORT=3DU_EXPORT -I../= .. -Igen -I../../third_party/perfetto/include -Igen/third_party/perfetto/build_config -Igen/third_party/perfetto -Igen/shim_headers/libevent_shim -Igen/shim_headers/icui18n_shim -Igen/shim_headers/icuuc_shim -I../../net/third_party/quiche/overrides -I../../net/third_party/quiche/src/quiche/common/platform/default -I../../net/third_party/quiche/src -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/abseil-cpp -I../../third_party/boringssl/src/include -Igen/net/third_party/quiche/src -I../../third_party/zlib -I../../third_party/ced/src -I../../third_party/brotli/include -Wall -Wextra -Wimplicit-fallthrough -Wextra-semi -Wunreachable-code-aggressive -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wloop-analysis -Wno-unneeded-internal-declaration -Wenum-compare-condition= al -Wno-ignored-pragma-optimize -Wshadow -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing --param=3Dssp-buffer-size=3D4 -fstack-prote= ctor -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pthread -fcolor-diagnostics -fmerge-all-constants -m64 -msse3 -Xclang -fdebug-compilation-dir -Xclang . -no-canonical-prefixes -ftrivial-auto-var-init=3Dpattern -O2 -fdata-sections -ffunction-sections -fno-unique-section-names -fno-omit-frame-pointer -g0 -fprofile-use=3D../../chrome/build/pgo_profiles/chrome-linux-5938-169419327= 3-9204 1abba5ed60196170382dbce223833adce5c9.profdata -Wno-profile-instr-unprofiled -Wno-profile-instr-out-of-date -Wno-backend-plugin -fvisibility=3Dhidden -Wheader-hygiene -Wstring-convers= ion -Wtautological-overlap-compare -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -DPROTOBUF_ALLOW_DEPRECATED=3D1 -Wexit-time-destructors -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include -I/usr/local/include -std=3Dc++20 -Wno-trigraphs -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing=20 -isystem /usr/local/include -c ../../net/dns/address_info.cc -o obj/net/dns/dns/address_info.o ../../net/dns/address_info.cc:81:47: error: use of undeclared identifier 'EAI_NODATA' if (os_error !=3D EAI_NONAME && os_error !=3D EAI_NODATA) ^ 1 error generated. As noted in the cited email message, this does not occur in 13 because of: commit 870d2ff3052822dd6b46f2c07c442926d637130b Author: Mike Karels <karels@FreeBSD.org> Date: Wed Nov 2 10:43:04 2022 -0500 netdb.h: re-enable EAI_ADDRFAMILY, EAI_NODATA EAI_ADDRFAMILY and EAI_NODATA are not in RFC 3493, but are available and used in many other systems. It is desirable to have at least one of them in order to distinguish between names that do not resolve and those that do not have the requested address type. A change to getaddrinfo() will use EAI_ADDRFAMILY. Both were "#if 0"; re-enable, conditioned on __BSD_VISIBLE, and update comments. Also add comments and __BSD_VISIBLE conditional for the last three EAI errors, which are not in the RFC or POSIX. Note, all of these are available in NetBSD and OpenBSD, and EAI_ADDRFAMILY and EAI_NODATA are available in Linux (glibc). Reviewed in https://reviews.freebsd.org/D37139 with related changes. Reviewed by: bz (cherry picked from commit 40e4e12bd84154626d5b46c3e862c79da25bc403)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-274139-28929-Enzzmwmm0Q>