From owner-freebsd-bugs@FreeBSD.ORG Sun Jan 27 19:50:01 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 962DE16A41B for ; Sun, 27 Jan 2008 19:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 6C27E13C45A for ; Sun, 27 Jan 2008 19:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m0RJo1Hp034556 for ; Sun, 27 Jan 2008 19:50:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m0RJo0SQ034555; Sun, 27 Jan 2008 19:50:01 GMT (envelope-from gnats) Resent-Date: Sun, 27 Jan 2008 19:50:01 GMT Resent-Message-Id: <200801271950.m0RJo0SQ034555@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ermal Luçi Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2AB0216A417 for ; Sun, 27 Jan 2008 19:46:37 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 140EE13C455 for ; Sun, 27 Jan 2008 19:46:37 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m0RJisLr075039 for ; Sun, 27 Jan 2008 19:44:54 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m0RJis1c075038; Sun, 27 Jan 2008 19:44:54 GMT (envelope-from nobody) Message-Id: <200801271944.m0RJis1c075038@www.freebsd.org> Date: Sun, 27 Jan 2008 19:44:54 GMT From: Ermal Luçi To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/120057: Allow propper settings of ALTQ_HFSC. The check i wrong since even with the values forbidden from this check you get a concave curve. X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jan 2008 19:50:01 -0000 >Number: 120057 >Category: misc >Synopsis: Allow propper settings of ALTQ_HFSC. The check i wrong since even with the values forbidden from this check you get a concave curve. >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Jan 27 19:50:00 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Ermal Luçi >Release: HEAD >Organization: >Environment: FreeBSD 8.0-CURRENT FreeBSD 8.0-CURRENT #2: Mon Dec 17 22:57:03 CET 2007 root@:/usr/obj/usr/home/eri/development/compile/src/sys/GENERIC amd64 >Description: The authors of PF mistankely have inserted this patch which doesn't allow propper configuration of ALTQ_HFSC. With these parameters you can get a concave curve! Even if you read the paper dedicated to HFSC on acm.org you will see that the original author used a curve prohibitted by authors of PF. >How-To-Repeat: >Fix: Patch attached with submission follows: Index: pfctl_altq.c =================================================================== RCS file: /home/eri/FreeBSD/src/contrib/pf/pfctl/pfctl_altq.c,v retrieving revision 1.9 diff -u -r1.9 pfctl_altq.c --- pfctl_altq.c 3 Jul 2007 12:30:02 -0000 1.9 +++ pfctl_altq.c 27 Jan 2008 19:41:11 -0000 @@ -690,13 +690,6 @@ return (-1); } - if ((opts->rtsc_m1 < opts->rtsc_m2 && opts->rtsc_m1 != 0) || - (opts->lssc_m1 < opts->lssc_m2 && opts->lssc_m1 != 0) || - (opts->ulsc_m1 < opts->ulsc_m2 && opts->ulsc_m1 != 0)) { - warnx("m1 must be zero for convex curve: %s", pa->qname); - return (-1); - } - /* * admission control: * for the real-time service curve, the sum of the service curves >Release-Note: >Audit-Trail: >Unformatted: