From owner-cvs-src@FreeBSD.ORG  Fri Apr  4 07:36:03 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 008BA37B401
	for <cvs-src@FreeBSD.org>; Fri,  4 Apr 2003 07:36:02 -0800 (PST)
Received: from sleet.ispgateway.de (sleet.ispgateway.de [62.67.200.125])
	by mx1.FreeBSD.org (Postfix) with SMTP id 5261C43FBD
	for <cvs-src@FreeBSD.org>; Fri,  4 Apr 2003 07:36:00 -0800 (PST)
	(envelope-from robert@zoot.drehmel.com)
Received: (qmail 10554 invoked from network); 4 Apr 2003 15:35:59 -0000
Received: from unknown (HELO bsd.develop.ferrari.local)
	(948464@[62.159.79.193]) (envelope-sender <robert@zoot.drehmel.com>)
	by sleet.ispgateway.de (qmail-ldap-1.03) with SMTP
	for <cvs-all@FreeBSD.org>; 4 Apr 2003 15:35:59 -0000
Received: (from robert@localhost)
	by bsd.develop.ferrari.local (8.12.6/8.11.5) id h34FUQl4026330;
	Fri, 4 Apr 2003 17:30:26 +0200 (CEST)
	(envelope-from robert)
Date: Fri, 4 Apr 2003 17:30:26 +0200
From: Robert Drehmel <robert@zoot.drehmel.com>
To: robert@FreeBSD.org
Message-ID: <20030404153026.GA26280@bsd.develop.ferrari.local>
References: <200304041440.h34Eenq6008187@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200304041440.h34Eenq6008187@repoman.freebsd.org>
User-Agent: Mutt/1.4i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/pkg_install/version perform.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Apr 2003 15:36:03 -0000

On Fri, Apr 04, 2003 at 06:40:49AM -0800, Robert Drehmel wrote:
> robert      2003/04/04 06:40:49 PST
> 
>   FreeBSD src repository
> 
>   Modified files:
>     usr.sbin/pkg_install/version perform.c 
>   Log:
>    - Print out an error message instead of dereferencing a NULL pointer
>      if matchinstalled() found no packages, which happens to be the
>      case after fresh installations.
>    - Instead of using strstr(3) to match the package name, depend on
>      matchinstalled()'s MATCH_REGEX package matching.

MATCH_REGEX is not quite correct but only used to be similar to previous
behaviour.  It think the options of pkg_version should be changed to
match those of pkg_info - at least to be able to say

 $ pkg_info pkg_name ...
 $ pkg_info -x pkg_regex

and

 $ pkg_version pkg_name ...
 $ pkg_version -x pkg_regex

Comments?

ciao,
-robert