From nobody Fri Oct 21 11:04:19 2022 X-Original-To: x11@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Mv1nQ1B4nz4gCv7; Fri, 21 Oct 2022 11:04:26 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Mv1nQ0gGSz3X19; Fri, 21 Oct 2022 11:04:26 +0000 (UTC) (envelope-from jbeich@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1666350266; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P+c/HgTsevts7FhTKbf9o83yZ7/z+cBp3div9BEW58c=; b=l8BguJ9O9fRJAOUZ3vJgYSZj2Qdf/U86Z2ZRxIiVpyfSjfUcdSZyBFuE+rToPa60Su+MUd RkGny5gKQX1vaIqbqS8OYvh2+nhUYnIdWqupd2112eetPcnJKxhN8/QVTh5vanbXi+oLwJ xUq7f0Bt8zTpeDpKbF5baOrzzePVuAavoHIjCuv1eqksWfPmwmKwIA21MrGuugyFDld2TW f1P6FP5StOWLX2JbrPw4EeG+tGT5scuuhWgd6eP89xErKXpsji1fOhT5kqOqNfFci29ber /91+hQKRMTTVHYIrrdvD1TGsQrLo61uqjCZujKf0J3ji1uipAkZIFg2r6bzKqA== Received: by freefall.freebsd.org (Postfix, from userid 1354) id EFDB31B03D; Fri, 21 Oct 2022 11:04:25 +0000 (UTC) From: Jan Beich To: pkg-fallout@FreeBSD.org Cc: x11@FreeBSD.org Subject: graphics/drm-510-kmod is broken on aarch64 (Was: [package - main-arm64-default][graphics/drm-510-kmod] Failed for drm-510-kmod-5.10.113_7 in build) In-Reply-To: <202210192239.29JMdSjJ086499__20975.2127224178$1666219180$gmane$org@ampere2.nyi.freebsd.org> (pkg-fallout@freebsd.org's message of "Wed, 19 Oct 2022 22:39:28 GMT") References: <202210192239.29JMdSjJ086499__20975.2127224178$1666219180$gmane$org@ampere2.nyi.freebsd.org> Date: Fri, 21 Oct 2022 13:04:19 +0200 Message-ID: <4jvx-h1zg-wny@FreeBSD.org> List-Id: X11 List-Archive: https://lists.freebsd.org/archives/freebsd-x11 List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-x11@freebsd.org X-BeenThere: freebsd-x11@freebsd.org MIME-Version: 1.0 Content-Type: text/plain ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1666350266; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P+c/HgTsevts7FhTKbf9o83yZ7/z+cBp3div9BEW58c=; b=tlSDUJgMY5AUgr5NssbQ6nA6MWC4rLrzsz7/J5b7mGQbr8velqTpDTKhvOPrUqt893XdIU i+QZyUge4Ll0athNSPTtfthen4SoNDb124hSMhDvK7VuHpaa5usg7zD0qqlXAThkCnSMlP EtZxw0UbfsyU3mZaJxZjOZ75jJoxdjI4FuGeNph4rVyCSgc7NPBt+E07rYyc6PlD5hh7Ej hzTrKa3anTMpXyeEPI3VcO0I7uTOsLy4tdKLR3uIoZPRFNKxMGYWVdEGBN6IwQQaJixxJg BXFj+8dgplbTHPnzDTK0jhSB16vi4OmsjB4u9Tk+1iCAzGjt9WXYQYj3FhCMvQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1666350266; a=rsa-sha256; cv=none; b=q14OeZ+T4b5nB7ELb1DK3HOEFHsWcKbzQY30sXfwoM9U8BonEcN4yuxWP7ksxC4ViwscKg sAbHEOURPOez+6Pd9dbx7uVXWjm491tJAjWrH0KUPZI7zvgUP8j6HB/DAy3/dgeaotoYY6 FIq3uKMjGrO3xmkQ1sjwg4AqUxsboZrS8lHNiCQLff3U4T23uOUbqTwk3GUcAbwgU9bFGL KmATsfjX19osL0oeHl8oe2WyaOhKu1i621bcoG0Nr3y02Iyck2emyiemxQ1qWIOy4xOtFX /y39w0ztxzJHoj8hDpA2yYl/kVKEH91qPjQTeB97xha6UfTyCoeFaFnNd0GvQA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N pkg-fallout@FreeBSD.org writes: > /wrkdirs/usr/ports/graphics/drm-510-kmod/work/drm-kmod-drm_v5.10.113_8/drivers/dma-buf/sync_file.c:394:3: error: implicit declaration of function 'cpu_relax' is invalid in C99 [-Werror,-Wimplicit-function-declaration] > cpu_relax(); > ^ > /wrkdirs/usr/ports/graphics/drm-510-kmod/work/drm-kmod-drm_v5.10.113_8/drivers/dma-buf/sync_file.c:394:3: note: did you mean 'cpu_reset'? > ./machine/cpu.h:187:6: note: 'cpu_reset' declared here > void cpu_reset(void) __dead2; > ^ > 1 error generated. I wonder why pkg-fallout@ is silent about 13.1. aarch64 (arm64) is Tier1 since 13.0. https://pkg-status.freebsd.org/ampere3/data/131arm64-default/9f2f3869d429/logs/errors/drm-510-kmod-5.10.113_7.log https://pkg-status.freebsd.org/ampere1/data/131arm64-quarterly/9b8cd91058a0/logs/errors/drm-510-kmod-5.10.113_7.log .../drm-kmod-drm_v5.10.113_8/drivers/gpu/drm/amd/display/dc/core/dc.c:741:3: error: implicit declaration of function 'DC_FP_START' is invalid in C99 [-Werror,-Wimplicit-function-declaration] DC_FP_START(); ^ .../drm-kmod-drm_v5.10.113_8/drivers/gpu/drm/amd/display/dc/core/dc.c:743:3: error: implicit declaration of function 'DC_FP_END' is invalid in C99 [-Werror,-Wimplicit-function-declaration] DC_FP_END(); ^ 2 errors generated. https://github.com/freebsd/drm-kmod/commit/bf687fd43411 can probably be extended to aarch64. While enough to unbreak 13.1 I can't test runtime due to no hardware. diff --git a/drivers/gpu/drm/amd/display/dc/os_types.h b/drivers/gpu/drm/amd/display/dc/os_types.h index 28ddfad27c..396907a1f2 100644 --- a/drivers/gpu/drm/amd/display/dc/os_types.h +++ b/drivers/gpu/drm/amd/display/dc/os_types.h @@ -55,8 +55,7 @@ #include #define DC_FP_START() kernel_fpu_begin() #define DC_FP_END() kernel_fpu_end() -#elif defined(CONFIG_PPC64) -#ifdef __linux__ +#elif defined(CONFIG_PPC64) && defined(__linux__) #include #include #define DC_FP_START() { \ @@ -83,12 +82,11 @@ preempt_enable(); \ } \ } -#elif defined(__FreeBSD__) +#else #define DC_FP_START() #define DC_FP_END() #endif #endif -#endif /* *