Date: Tue, 25 Jul 2017 22:31:36 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 220950] Mk/Scripts/check-stagedir.sh false negatives (with %%OPTIONS%%) Message-ID: <bug-220950-13-T4EaP0vDIF@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-220950-13@https.bugs.freebsd.org/bugzilla/> References: <bug-220950-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220950 --- Comment #2 from Mathieu Arnold <mat@FreeBSD.org> --- (In reply to Gerald Pfeifer from comment #0) > It appears that Mk/Scripts/check-stagedir.sh completely misses files that > appear > - in the staging directory, and > - are listed in pkg-plist with an %%OPTION%% prefix when OPTION is off. >=20 > Those files should be included in packages (or when the port is installed= ), > but > are not. No they should not. The files should only be included if opt is enabled. There are many, many, ports that stage all the files but only package them = if some options are enabled. > And check-stagedir.sh should diagnose that those files are in stagedir, b= ut > not included in pkg-plist. Well, it might be an idea to say something, like "this file is installed but not packaged" but it must not be either a warning or an error. > This is quite a problem! This is a problem in *1* port, but "fixing" it in the framework would break many, many ports. >=20 > How to reproduce: >=20 > 1. chdir $PORTSDIR/emulators/wine-devel > 2. svn up -r 445571 (the version before I'll fix pkg-plist in a minute) > 3. Run the following script (after adjusting STAGEDIR and PREFIX) >=20 > #!/bin/sh >=20 > STAGEDIR=3D$WRKDIRPREFIX/wine-devel-work/stage > PREFIX=3D$WRKDIRPREFIX/wine-devel-prefix >=20 > grep %%STAGING%% pkg-plist | while read f; do > f=3D`echo $f | sed -e 's/%%STAGING%%//'` > if [ -f "$STAGEDIR/$PREFIX/$f" ]; then > printf "%s no longer contigent on %%STAGING%%?\n" "$f" > fi > done --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-220950-13-T4EaP0vDIF>