From nobody Thu Aug 17 06:03:40 2023 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RRDw04qcTz4qGpF for ; Thu, 17 Aug 2023 06:03:44 +0000 (UTC) (envelope-from felix@palmen-it.de) Received: from stef.palmen-it.de (stef.palmen-it.de [IPv6:2001:470:1f0b:bbb:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4RRDvz58Ypz3XyW for ; Thu, 17 Aug 2023 06:03:43 +0000 (UTC) (envelope-from felix@palmen-it.de) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=palmen-it.de header.s=20200414 header.b=wDxqsbDp; spf=pass (mx1.freebsd.org: domain of felix@palmen-it.de designates 2001:470:1f0b:bbb:1::1 as permitted sender) smtp.mailfrom=felix@palmen-it.de; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=palmen-it.de; s=20200414; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:To:From:Date:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=hzO8qtzBSGZgORMCOUN0jmuBhPzurguPuic+bPZGHTU=; b=wDxqsbDpvqo28MhtyuvJ13sd4r PLG/uQlAXmOIM3dYq5xraiCPdYFYQdGIRA2mHS7ka1Zbv9Sv3fmV2aPhm/o6FjfmslsaJx5C6hQB0 +IBAR9WxgQ6MHVpKID0ciREvFnId57TkS5bV/dH2NfOAhpawwmbBpJ1QpFRkHx/JD47l5zre9Uabi nU3BEEmMT2VZfsEFs8wf+NsZ+VMuOuLhoQqXe7fg0bP1J2o09SPjY8o99KNOXj+gHauvGIqDZO1/R NLc7poKSBqH1pkMyaCVG4+pSIo4DT9i7ukUW8kPt36+NzdmkWQ+cMGvIYzn6w6ya+AfZojnmasibY datE048g==; Received: from [192.168.71.101] (helo=mail.home.palmen-it.de) by stef.palmen-it.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qWW6f-009xL2-IR for ports@freebsd.org; Thu, 17 Aug 2023 08:03:41 +0200 Received: from nexus.home.palmen-it.de ([192.168.99.2]) by mail.home.palmen-it.de with esmtpsa (TLS1.3) tls TLS_CHACHA20_POLY1305_SHA256 (Exim 4.96 (FreeBSD)) (envelope-from ) id 1qWW6f-000NGP-17 for ports@freebsd.org; Thu, 17 Aug 2023 06:03:41 +0000 Date: Thu, 17 Aug 2023 08:03:40 +0200 From: Felix Palmen To: ports@freebsd.org Subject: Re: plist-check not reporting orphaned files present in a @comment Message-ID: Mail-Followup-To: ports@freebsd.org X-Face: /1K@t"h.}e~pR@]c7HorQ!T`F^RJCa'BCr#e>IKA{>C/9OTGB4|xh"y2{?1Z5M i2w"AH^pN_LlHR^{+f',_Np~;.B;!M/bL}*qk]p5*r7F5vW};{:@4u5S?T&f0$7BJ-71Q5SV]:v$`5 A0[DZ:=?S52x8HJ~5@^P_\T@MsjG{R( Organization: FreeBSD.org References: <5h3c6jbzs7y5k3hyimqn7jkyo3se3txvcywahpcffzc24hjew7@kx4mhnqq7gh4> <8raa-vofq-wny@FreeBSD.org> <2ppfted4t72jo2bhgxfmoghpm6zukhrcqevucxvouqqwehwugg@zy4chydjtuxy> <67hyj5pbnd2hf66tdj2szrtyhxozmjjcevw5rooas2vzrltxna@oqjzi7m5tfho> List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="a4za77ruynh7qh4h" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20230517 X-Spamd-Result: default: False [-7.46 / 15.00]; SIGNED_PGP(-2.00)[]; DWL_DNSWL_MED(-2.00)[palmen-it.de:dkim]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.96)[-0.956]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; FORGED_SENDER(0.30)[zirias@freebsd.org,felix@palmen-it.de]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:1f0b:bbb:1::1:c]; RCVD_IN_DNSWL_MED(-0.20)[2001:470:1f0b:bbb:1::1:from]; R_DKIM_ALLOW(-0.20)[palmen-it.de:s=20200414]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; DMARC_NA(0.00)[freebsd.org]; MLMMJ_DEST(0.00)[ports@freebsd.org]; FROM_HAS_DN(0.00)[]; TO_DOM_EQ_FROM_DOM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; HAS_ORG_HEADER(0.00)[]; TO_DN_NONE(0.00)[]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[palmen-it.de:+]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FROM_NEQ_ENVFROM(0.00)[zirias@freebsd.org,felix@palmen-it.de]; RCVD_TLS_ALL(0.00)[] X-Spamd-Bar: ------- X-Rspamd-Queue-Id: 4RRDvz58Ypz3XyW --a4za77ruynh7qh4h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Tatsuki Makino [20230817 07:57]: > Switching @comment by ${ARCH} is also in print/epson-inkjet-printer-escpr= 2. > This is not a problem with check-orphans. It is, when some file doesn't exist for all architectures, but for more than one of them. You first test the port on ARCH=3Dfoo. Then you test on ARCH=3Dbar and find that it builds/installs an additional tmp/something, so you prefix it with %%BAR%% which expands to "@comment " unless building on ARCH=3Dbar. Then you test on ARCH=3Dbaz which happens to build/install the same tmp/something. plist-check will still be happy because the file is there in pkg-plist (ignoring the @comment). Still, the file will be missing =66rom the package. I might try another workaround, e.g. expand to "@comment dummy/" instead, so the name won't match and plist-check will complain ... > However, linuxulator ports often switch plist file itself for different $= {ARCH}. Sure, but that's only suitable when a large portion of entries is indeed different depending on ${ARCH}. --=20 Felix Palmen {private} felix@palmen-it.de -- ports committer -- {web} http://palmen-it.de {pgp public key} http://palmen-it.de/pub.txt {pgp fingerprint} 6936 13D5 5BBF 4837 B212 3ACC 54AD E006 9879 F231 --a4za77ruynh7qh4h Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iNUEABYKAH0WIQRpNhPVW79IN7ISOsxUreAGmHnyMQUCZN24NV8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0Njkz NjEzRDU1QkJGNDgzN0IyMTIzQUNDNTRBREUwMDY5ODc5RjIzMQAKCRBUreAGmHny MdtZAP404zzFbCkfXi03BKhcqX2tnvtO82+Om5BwBL9V95BCiQD+IOVX6Fl1pqWN MaFVSsnPJGT9v5yI4gwWBjUX+zT/WwA= =J536 -----END PGP SIGNATURE----- --a4za77ruynh7qh4h--