From owner-dev-commits-src-all@freebsd.org Tue Sep 14 16:39:16 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A47BC66C43F; Tue, 14 Sep 2021 16:39:16 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4H88FJ40Pqz4pyv; Tue, 14 Sep 2021 16:39:16 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1631637556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ofYepXUz2iKK14qNbah/IDq1cJO7Je38EViZNaT/7D4=; b=sJwss9Tcc364JsgW1L5dCbcoozPaoFeXY4/b3guQ7Fw0MqUJ6FrE8F5mZ9x/EZHG8gwW+y iYlyAd1jfFViFqtDQhgiFyGP8owYnNr2klEia6oKogniuf3+iq9OMlvcMJ878ej++iLrVp 4uuBaDwVARMq1iqmzArFLprJiv02vPLm9Kk0uXqE0TtPINohym9DMtRbzxj6lOWKBU/kpF Tpj+2cKGVxIA9nuv5dPAQwKB+z5a5uuBQZu6qlLmeI55MXJPEgsV7TfzpXqPag7kx/Mma9 6v797E8BnqZUOsh4Lt5jk072YBxMJh3UOYQtCDAQdZYyrR1ZbCfKsJ4kBVONXg== Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 62D5871EF; Tue, 14 Sep 2021 16:39:16 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 96B5B7D02; Tue, 14 Sep 2021 09:39:15 -0700 (PDT) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id KAkljf4f3DHT; Tue, 14 Sep 2021 09:39:13 -0700 (PDT) Subject: Re: git: ddedf2a11eb2 - main - tzcode: Implement timezone change detection DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com 4B0B07CF5 To: Edward Tomasz Napierala , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202109131442.18DEgDIn043709@gitrepo.freebsd.org> From: Bryan Drewery Organization: FreeBSD Message-ID: <59a39614-45d2-d9b0-a84a-476e52a81c76@FreeBSD.org> Date: Tue, 14 Sep 2021 09:39:14 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <202109131442.18DEgDIn043709@gitrepo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wSgEHqHSqGi1wIEqfMGgf01N8RK7YaRGw" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1631637556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ofYepXUz2iKK14qNbah/IDq1cJO7Je38EViZNaT/7D4=; b=u/6TJOSHgKwB8T28EeVhtb59b8hm+V29dCvuxRbt6wRGgObehEuTHzuiliISba2KBwNz5h CsIo42jl2ipPfYV8yFjC/dC4K5nL839WwrApe+/jP5JjbWNIvtYu7A8RO4YBhgBPYNwbeX oI7v8hKR+URqFcgjyWXXHMeOUPuBGclC5bcFjJmvRh+VrYb6TUq0P5djEpzI5WdhSjDBwy l/tWmBvB/ibwlF3fXonIOwfKaja/9nd0x66WBl5hJpKZ+2ZMY8+v+epGSUIkJK4HTNQDaC SDQ+qSez7XxogJDDMxnMuBchJQkLtZkFnlOZ+x2HcwDYLctk5VH40dDeU/J05A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1631637556; a=rsa-sha256; cv=none; b=cU1qN1VRKql7m5hLqOMVAoVy9mk6HeCx0COQ55Ivo8ZMJfcXIuy7XWBuhs2dCN0okAPQcL EsqFKr0O41i4bOOMmcm4c/P/GjZgzjx7Vq0h4+r2OaQ4FA4kirQ80lNGsBhzTV3OO/2Ecd LMJuB/HOvjC+lHPSHRDdOAh9UJsONsKsS53ogUq2YfdQ8CHOTh/8+2oh8qTiAKNzD1MFft FNOYeVG/snv6i820jDLAoyzCrJVdxiGgImnCRIX1FGtHknNzzWgrFEIyIXj2XDt8kaZNw7 bk35TSYN/M/nxc6RGsVlZcQAuMj9cy3Kj09BrC66TDwSXqeceeF5l+Qh215VKQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Sep 2021 16:39:16 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wSgEHqHSqGi1wIEqfMGgf01N8RK7YaRGw Content-Type: multipart/mixed; boundary="U0hUOraZIKiLM0PKAMawQq5Vp3r1t51sj"; protected-headers="v1" From: Bryan Drewery To: Edward Tomasz Napierala , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Message-ID: <59a39614-45d2-d9b0-a84a-476e52a81c76@FreeBSD.org> Subject: Re: git: ddedf2a11eb2 - main - tzcode: Implement timezone change detection References: <202109131442.18DEgDIn043709@gitrepo.freebsd.org> In-Reply-To: <202109131442.18DEgDIn043709@gitrepo.freebsd.org> --U0hUOraZIKiLM0PKAMawQq5Vp3r1t51sj Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 9/13/2021 7:42 AM, Edward Tomasz Napierala wrote: > +#else /* !DETECT_TZ_CHANGES */ > +#define change_in_tz(X) 0 WITHOUT_DETECT_TZ_CHANGES: change_in_tz() =3D=3D 0 > +#endif /* !DETECT_TZ_CHANGES */ > + > static int > differ_by_repeat(const time_t t1, const time_t t0) > { > @@ -379,6 +418,7 @@ register const int doextend; > int stored; > int nread; > int res; > + int ret; > union { > struct tzhead tzhead; > char buf[2 * sizeof(struct tzhead) + > @@ -427,6 +467,22 @@ register const int doextend; > (void) strcat(fullname, name); > name =3D fullname; > } > + if (doextend =3D=3D TRUE) { > + /* > + * Detect if the timezone file has changed. Check > + * 'doextend' to ignore TZDEFRULES; the change_in_tz() > + * function can only keep state for a single file. > + */ > + ret =3D change_in_tz(name); > + if (ret <=3D 0) { WITHOUT_DETECT_TZ_CHANGES: Always returns a false-positive "done" but short-circuits the rest of tzload(). > + /* > + * Returns -1 if there was an error, > + * and 0 if the timezone had not changed. > + */ > + free(fullname); > + return ret; > + } > + } --=20 Regards, Bryan Drewery --U0hUOraZIKiLM0PKAMawQq5Vp3r1t51sj-- --wSgEHqHSqGi1wIEqfMGgf01N8RK7YaRGw Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEE+Rc8ssOq6npcih8JNddxu25Gl88FAmFA0DIFAwAAAAAACgkQNddxu25Gl88r hAgAltyUu1Bn2s6N+Vg0AHDgThsClWA1Fq7nmTu+45BSqIilAMUQk7Uf/CvdfxAU1u658fGPhnYp t25/fxRF4hDvyO0dN/Rmlbqx7HGInLYH6+HVPC+1SxTapR5mR54O8DxCOqVaF7wn5/tZXAQoVcZw Alzsc+/aIlhlsthPjiX/6utjdGaDawLJaf6ugEWNHJncQmY7UN/8u3kbqstw+V6Kd8rQikgoO+8s zx/4ABf1/vGylOK1JsisDCdM5buRbjU98B5E1uspXmdNzP8PDoknLXRDcgeX+Fs1sggL1pabrdrb OT9K74mDkG/GqSPMs2hJfrxNSCz8zfknP7Jb45My0g== =XIeD -----END PGP SIGNATURE----- --wSgEHqHSqGi1wIEqfMGgf01N8RK7YaRGw--