From owner-svn-src-all@freebsd.org Tue Jun 5 04:33:05 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CE913FF2AA2; Tue, 5 Jun 2018 04:33:05 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (unknown [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7F63D7E14E; Tue, 5 Jun 2018 04:33:05 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lf0-f44.google.com (mail-lf0-f44.google.com [209.85.215.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 18F7619CFF; Tue, 5 Jun 2018 04:33:05 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lf0-f44.google.com with SMTP id v135-v6so1315448lfa.9; Mon, 04 Jun 2018 21:33:05 -0700 (PDT) X-Gm-Message-State: ALKqPwcYo/AjnR5K9rZDKMrcrmQ1y5VbkjdBkMNVGF9kGwqz3rI+ZeRI zbt1lxvLdykAZD85UzfvA4AKOnTsU+exPnZmoOA= X-Google-Smtp-Source: ADUXVKJzJMKGiR6sI7Wv+UPQqVduOQ9RDx8Is/B9f0jOKe3Fw2G4X23GmX0Xj0jHd1fAbEX9bdcthxJptPjYuS/1f/o= X-Received: by 2002:a2e:1b0a:: with SMTP id b10-v6mr16726421ljb.76.1528173183606; Mon, 04 Jun 2018 21:33:03 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a2e:3112:0:0:0:0:0 with HTTP; Mon, 4 Jun 2018 21:32:43 -0700 (PDT) In-Reply-To: References: <201805252146.w4PLk7vL009258@repo.freebsd.org> From: Kyle Evans Date: Mon, 4 Jun 2018 23:32:43 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r334226 - head/lib/libpmcstat/pmu-events To: Bryan Drewery Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2018 04:33:06 -0000 On Mon, Jun 4, 2018 at 10:11 PM, Kyle Evans wrote: > On Fri, May 25, 2018 at 4:46 PM, Bryan Drewery wrote: >> Author: bdrewery >> Date: Fri May 25 21:46:07 2018 >> New Revision: 334226 >> URL: https://svnweb.freebsd.org/changeset/base/334226 >> >> Log: >> Cleanup style >> >> Modified: >> head/lib/libpmcstat/pmu-events/Makefile >> >> Modified: head/lib/libpmcstat/pmu-events/Makefile >> ============================================================================== >> --- head/lib/libpmcstat/pmu-events/Makefile Fri May 25 20:42:28 2018 (r334225) >> +++ head/lib/libpmcstat/pmu-events/Makefile Fri May 25 21:46:07 2018 (r334226) >> @@ -1,9 +1,10 @@ >> # $FreeBSD$ >> >> -PROG=jevents >> -SRCS=jevents.c jsmn.c json.c >> +PROG= jevents >> +SRCS= jevents.c jsmn.c json.c >> CFLAGS+= -Wno-cast-qual >> -.PATH: ${.CURDIR} >> -build-tools: jevents >> MAN= >> + >> +build-tools: jevents >> + >> .include >> > > Hi Bryan, > > Something about this appears to be subtly wrong, but I can't quite pin > down what. I'm getting a failure in the lib32 build of libpmc: > > sh: ./pmu-events/jevents: not found > > My observations are that ${OBJDIR}/lib/libpmc/pmu-events/jevents > exists, as does ${SRCTOP}/lib/libpmc/pmu-events/jevents. > ${OBJDIR}/obj-lib32/lib/libpmc, OTOH, only contains _INCSINS.meta and > libpmc_events.c.meta. I'm guessing this is the problem- that > obj-lib32/... doesn't have the built jevents, but it's not obvious to > me why this is the case. Some additional context: SRCCONF is defined to a file that looks like this: WITH_BSD_GREP="YES" WITHOUT_BSD_GREP_FASTMATCH="YES" WITH_LOADER_LUA="YES" WITHOUT_FORTH="YES" _SRC_ENV_CONF and __MAKE_CONF are set to /dev/null; all three set in arguments to make(1). OBJDIR has been completely wiped before-hand.