From owner-svn-src-all@freebsd.org Wed Dec 6 01:17:30 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2BBB0E8A5F7; Wed, 6 Dec 2017 01:17:30 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f50.google.com (mail-it0-f50.google.com [209.85.214.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9F5857C5C9; Wed, 6 Dec 2017 01:17:29 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f50.google.com with SMTP id 68so5196640ite.4; Tue, 05 Dec 2017 17:17:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=QqLCxn6qPBtYVRht5fBLO6r+HroTRgudmgGx6DhgMOc=; b=W7WohaKjXmRNzOdZfkbFZIf5/gt3oA5zTJGpfvAi1t35bUWxXWhOxTRPabL6XAuf1+ YJhuwYlvNeZvlh3QXTAHsgmPjIE6bP/+Lm7FbE4cx+rL1tGgAKb44hjIouFSTKSkXQax vlRCR8xFdbvvjwBFbT1PhYksJ84EBA205zKERFRiRQT+ZR7mHato1EFwNO+wqqKAA5C0 9swuZrrG5WTEYhH9lVAI2k376W9idqkmMLncnffPULUf/GOX0G2TfDEmyettLqYoAIVc rP2boaa/wEz4yKWIFMQUO7Oa9M7xkrwcK63BrHf4do2Y5Fm7DKCuC92X1U+MBQW6/Iz9 fjTA== X-Gm-Message-State: AKGB3mJO3wSFOzJkBnvLR+GvxgRSn1d8vtUxK8iH9xSuBxv4OG6AnbWZ doHBBrzqdxfmwFYaENhKqMCkjjMN X-Google-Smtp-Source: AGs4zMYEdAeD1sR/w9x+N+wjwPK4C0i5MOrp0GVRYJwdT8nqfaFNl+wGNnjrHFGQd6O+250lQ+W1qA== X-Received: by 10.36.22.10 with SMTP id a10mr11771551ita.39.1512523043481; Tue, 05 Dec 2017 17:17:23 -0800 (PST) Received: from mail-io0-f178.google.com (mail-io0-f178.google.com. [209.85.223.178]) by smtp.gmail.com with ESMTPSA id o71sm809452itc.30.2017.12.05.17.17.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Dec 2017 17:17:23 -0800 (PST) Received: by mail-io0-f178.google.com with SMTP id d16so846302iob.4; Tue, 05 Dec 2017 17:17:23 -0800 (PST) X-Received: by 10.107.158.193 with SMTP id h184mr31562613ioe.256.1512523042980; Tue, 05 Dec 2017 17:17:22 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.2.165.150 with HTTP; Tue, 5 Dec 2017 17:17:22 -0800 (PST) In-Reply-To: References: <201704152015.v3FKFiwZ006836@repo.freebsd.org> From: Conrad Meyer Date: Tue, 5 Dec 2017 17:17:22 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r316980 - head/contrib/zstd/programs To: Baptiste Daroussin Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org, Allan Jude Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2017 01:17:30 -0000 Ping. Please revert this change. If you want zstd to behave this way, pursue it upstream first. Thanks, Conrad On Wed, Nov 15, 2017 at 7:38 PM, Conrad Meyer wrote: > Please revert this change. > > First, it introduces the POLA-violating behavior that zstdcat deletes > its source files. This is not how zcat/bzcat behaves. > > Second, it introduces a needless behavioral difference between FreeBSD > zstd and the rest of the world's zstd. The zstd documentation we ship > continues to claim that zstd preserves source files by default, yet > this change makes that documentation exactly backwards. While we can > change FreeBSD's documentation to accommodate the change, we can't > change Google results. > > Thanks, > Conrad > > On Sat, Apr 15, 2017 at 1:15 PM, Baptiste Daroussin wrote: >> Author: bapt >> Date: Sat Apr 15 20:15:44 2017 >> New Revision: 316980 >> URL: https://svnweb.freebsd.org/changeset/base/316980 >> >> Log: >> Change some default to make zstd a dropin replacement for gzip,bzip etc >> in most cases >> >> Changes ares: >> - quiet by default >> - remove the source files one compression completion by default >> >> Modified: >> head/contrib/zstd/programs/fileio.c >> head/contrib/zstd/programs/zstdcli.c >> >> Modified: head/contrib/zstd/programs/fileio.c >> ============================================================================== >> --- head/contrib/zstd/programs/fileio.c Sat Apr 15 20:06:24 2017 (r316979) >> +++ head/contrib/zstd/programs/fileio.c Sat Apr 15 20:15:44 2017 (r316980) >> @@ -138,7 +138,7 @@ static U32 g_dictIDFlag = 1; >> void FIO_setDictIDFlag(unsigned dictIDFlag) { g_dictIDFlag = dictIDFlag; } >> static U32 g_checksumFlag = 1; >> void FIO_setChecksumFlag(unsigned checksumFlag) { g_checksumFlag = checksumFlag; } >> -static U32 g_removeSrcFile = 0; >> +static U32 g_removeSrcFile = 1; >> void FIO_setRemoveSrcFile(unsigned flag) { g_removeSrcFile = (flag>0); } >> static U32 g_memLimit = 0; >> void FIO_setMemLimit(unsigned memLimit) { g_memLimit = memLimit; } >> >> Modified: head/contrib/zstd/programs/zstdcli.c >> ============================================================================== >> --- head/contrib/zstd/programs/zstdcli.c Sat Apr 15 20:06:24 2017 (r316979) >> +++ head/contrib/zstd/programs/zstdcli.c Sat Apr 15 20:15:44 2017 (r316980) >> @@ -61,7 +61,7 @@ >> #define MB *(1 <<20) >> #define GB *(1U<<30) >> >> -#define DEFAULT_DISPLAY_LEVEL 2 >> +#define DEFAULT_DISPLAY_LEVEL 1 >> >> static const char* g_defaultDictName = "dictionary"; >> static const unsigned g_defaultMaxDictSize = 110 KB; >>